Merge branch '2.19'

Author: cowtowncoder

release-notes/VERSION-2.x

@@ -83,6 +83,8 @@ Project: jackson-databind
  (contributed by @pjfanning)
 #5052: Minor bug in `FirstCharBasedValidator.forFirstNameRule()`: returns `null`
   in non-default case
+#5069: Add copy-constructor for `MappingIterator`
+ (contributed by @wrongwrong)
 
 2.18.3 (28-Feb-2025)
 

src/main/java/tools/jackson/databind/MappingIterator.java

@@ -165,6 +165,16 @@ protected MappingIterator(JavaType type, JsonParser p, DeserializationContext ct
         }
     }
 
+    /**
+     * Copy-constructor that sub-classes can use when creating new instances
+     * by fluent-style construction.
+     *
+     * @since 2.19
+     */
+    protected MappingIterator(MappingIterator<T> src) {
+        this(src._type, src._parser, src._context, src._deserializer, src._closeParser, src._updatedValue);
+    }
+
     /**
      * Method for getting an "empty" iterator instance: one that never
      * has more values; may be freely shared.

src/test/java/tools/jackson/databind/records/RecordWithReadOnlyTest.java

@@ -11,8 +11,8 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-public class RecordWithReadOnlyTest extends DatabindTestUtil {
-
+public class RecordWithReadOnlyTest extends DatabindTestUtil
+{
     record RecordWithReadOnly(int id, @JsonProperty(access = Access.READ_ONLY) String name) {
     }
 
@@ -97,7 +97,10 @@ public void testSerializeReadOnlyNamedProperty() throws Exception {
     public void testDeserializeReadOnlyNamedProperty() throws Exception {
         RecordWithReadOnlyNamedProperty value = MAPPER.readValue(a2q("{'id':123,'name':'Bob'}"),
                 RecordWithReadOnlyNamedProperty.class);
-        assertEquals(new RecordWithReadOnlyNamedProperty(123, "Bob"), value); // BUG: should be `null` instead of "Bob"
+
+        // BUG: should be `null` instead of "Bob"
+        // 01-Apr-2025, tatu: Should be in "tofix", then?
+        assertEquals(new RecordWithReadOnlyNamedProperty(123, "Bob"), value);
     }
 
     /*

src/test/java/tools/jackson/databind/records/tofix/RecordWithReadOnly5049Test.java

@@ -0,0 +1,60 @@
+package tools.jackson.databind.records.tofix;
+
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+import tools.jackson.databind.ObjectMapper;
+import tools.jackson.databind.testutil.DatabindTestUtil;
+import tools.jackson.databind.testutil.failure.JacksonTestFailureExpected;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+public class RecordWithReadOnly5049Test extends DatabindTestUtil
+{
+    record ReadOnly5049Record(
+            @JsonProperty(value = "a", access = JsonProperty.Access.READ_ONLY) String a,
+            @JsonProperty(value = "b", access = JsonProperty.Access.READ_ONLY) String b) {
+    }
+
+    static class ReadOnly5049Pojo
+    {
+        protected String a, b;
+
+        ReadOnly5049Pojo(
+            @JsonProperty(value = "a", access = JsonProperty.Access.READ_ONLY) String a,
+            @JsonProperty(value = "b", access = JsonProperty.Access.READ_ONLY) String b) {
+            this.a = a;
+            this.b = b;
+        }
+
+        public String getA() { return a; }
+        public String getB() { return b; }
+    }
+
+    private final ObjectMapper MAPPER = newJsonMapper();
+
+    @Test
+    void testRoundtripPOJO() throws Exception
+    {
+        String json = MAPPER.writeValueAsString(new ReadOnly5049Pojo("hello", "world"));
+        //System.err.println("JSON/pojo: "+json);
+        ReadOnly5049Pojo pojo = MAPPER.readerFor(ReadOnly5049Pojo.class).readValue(json);
+        assertNotNull(pojo);
+        assertNull(pojo.a);
+        assertNull(pojo.b);
+    } 
+
+    @JacksonTestFailureExpected
+    @Test
+    void testRoundtripRecord() throws Exception
+    {
+        // json = MAPPER.writeValueAsString(new ReadOnly5049Record("hello", "world"));
+        String json = "{\"a\":\"hello\",\"b\":\"world\"}";
+        ReadOnly5049Record record = MAPPER.readValue(json, ReadOnly5049Record.class);
+        assertNotNull(record);
+        assertNull(record.a());
+        assertNull(record.b());
+    }
+}