Merge branch '2.18' into 2.19

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/ObjectMapper.java

@@ -3656,6 +3656,8 @@ public <T extends JsonNode> T valueToTree(Object fromValue)
      *  serializable)
      *
      * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0
+     * It is recommended to try directly testing serialization using actual JSON inputs and outputs
+     * in test cases to ensure correctness and compatibility with real-world use cases.
      */
     @Deprecated // @since 2.18
     public boolean canSerialize(Class<?> type) {
@@ -3670,6 +3672,8 @@ public boolean canSerialize(Class<?> type) {
      * @since 2.3
      *
      * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0
+     * It is recommended to try directly testing serialization using actual JSON inputs and outputs
+     * in test cases to ensure correctness and compatibility with real-world use cases.
      */
     @Deprecated // @since 2.18
     public boolean canSerialize(Class<?> type, AtomicReference<Throwable> cause) {
@@ -3694,6 +3698,8 @@ public boolean canSerialize(Class<?> type, AtomicReference<Throwable> cause) {
      *  serializable)
      *
      * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0
+     * It is recommended to try directly testing deserialization using actual JSON inputs and outputs
+     * in test cases to ensure correctness and compatibility with real-world use cases.
      */
     @Deprecated // @since 2.18
     public boolean canDeserialize(JavaType type)
@@ -3710,6 +3716,8 @@ public boolean canDeserialize(JavaType type)
      * @since 2.3
      *
      * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0
+     * It is recommended to try directly testing deserialization using actual JSON inputs and outputs
+     * in test cases to ensure correctness and compatibility with real-world use cases.
      */
     @Deprecated // @since 2.18
     public boolean canDeserialize(JavaType type, AtomicReference<Throwable> cause)

src/main/java/com/fasterxml/jackson/databind/ObjectWriter.java

@@ -1215,6 +1215,8 @@ public void acceptJsonFormatVisitor(Class<?> type, JsonFormatVisitorWrapper visi
      * it could serialize an instance of given Class.
      *
      * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0
+     * It is recommended to try directly testing serialization using actual JSON inputs and outputs
+     * in test cases to ensure correctness and compatibility with real-world use cases.
      */
     @Deprecated // @since 2.18
     public boolean canSerialize(Class<?> type) {
@@ -1229,6 +1231,8 @@ public boolean canSerialize(Class<?> type) {
      * @since 2.3
      *
      * @deprecated Since 2.18 use discouraged; method to be removed from Jackson 3.0
+     * It is recommended to try directly testing serialization using actual JSON inputs and outputs
+     * in test cases to ensure correctness and compatibility with real-world use cases.
      */
     @Deprecated // @since 2.18
     public boolean canSerialize(Class<?> type, AtomicReference<Throwable> cause) {

src/test/java/com/fasterxml/jackson/databind/tofix/CreatorWithIgnoreProperties3355Test.java

@@ -0,0 +1,84 @@
+package com.fasterxml.jackson.databind.tofix;
+
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
+import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+// [databind#3355] Deserialization fails depending on the order of deserialized
+// objects with "Cannot construct instance (although at least one Creator exists)"
+public class CreatorWithIgnoreProperties3355Test
+    extends DatabindTestUtil
+{
+    static class Common3355 {
+        private final String property;
+        private final ContainerFail3355 container;
+
+        @JsonCreator
+        public Common3355(@JsonProperty("property") final String property,
+                          @JsonProperty("container") final ContainerFail3355 container) {
+            this.property = property;
+            this.container = container;
+        }
+
+        public String getProperty() {
+            return property;
+        }
+
+        public ContainerFail3355 getContainer() {
+            return container;
+        }
+    }
+
+    static class ContainerFail3355 {
+        private final Common3355 common;
+
+        @JsonCreator
+        public ContainerFail3355(@JsonProperty("common") final Common3355 common) {
+            this.common = common;
+        }
+
+        @JsonIgnoreProperties("container")
+        public Common3355 getCommon() {
+            return common;
+        }
+    }
+
+    private final ObjectMapper MAPPER = newJsonMapper();
+
+    @JacksonTestFailureExpected
+    @Test
+    public void testDeserFailing() throws Exception
+    {
+        final String objectJson = "{ \"property\": \"valueOne\" }";
+        final String containersJson = "{ \"common\": { \"property\": \"valueTwo\" } }";
+
+        // If we deserialize inner object first, outer object FAILS
+        Common3355 object = MAPPER.readValue(objectJson, Common3355.class);
+        ContainerFail3355 container = MAPPER.readValue(containersJson, ContainerFail3355.class);
+
+        assertNotNull(object);
+        assertNotNull(container);
+    }
+
+    @Test
+    public void testDeserPassing() throws Exception
+    {
+        final String objectJson = "{ \"property\": \"valueOne\" }";
+        final String containersJson = "{ \"common\": { \"property\": \"valueTwo\" } }";
+
+        // If we deserialize outer object first, it WORKS
+        final ContainerFail3355 container = MAPPER.readValue(containersJson, ContainerFail3355.class);
+        final Common3355 object = MAPPER.readValue(objectJson, Common3355.class);
+
+        assertNotNull(object);
+        assertNotNull(container);
+    }
+}