Skip to content

Commit c0d5eb4

Browse files
committed
Fixes jackson-module-paranamer issue #5 problem with paranamer + PropertyNamingStrategy. Update the creator properties after renaming using PropertyNamingStrategy as per initial _renameProperties() call.
1 parent e5f9cf9 commit c0d5eb4

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -700,16 +700,8 @@ protected void _renameProperties()
700700
} else {
701701
old.addAll(prop);
702702
}
703-
704703
// replace the creatorProperty too, if there is one
705-
if (_creatorProperties != null) {
706-
for (int i = 0; i < _creatorProperties.size(); ++i) {
707-
if (_creatorProperties.get(i).getInternalName().equals(prop.getInternalName())) {
708-
_creatorProperties.set(i, prop);
709-
break;
710-
}
711-
}
712-
}
704+
updateCreatorProperty(prop);
713705
}
714706
}
715707
}
@@ -757,6 +749,8 @@ protected void _renameUsing(PropertyNamingStrategy naming)
757749
} else {
758750
old.addAll(prop);
759751
}
752+
753+
updateCreatorProperty(prop);
760754
}
761755
}
762756

@@ -858,4 +852,15 @@ private PropertyNamingStrategy _findNamingStrategy()
858852
return (PropertyNamingStrategy) ClassUtil.createInstance(namingClass,
859853
_config.canOverrideAccessModifiers());
860854
}
855+
856+
private void updateCreatorProperty(POJOPropertyBuilder prop) {
857+
if (_creatorProperties != null) {
858+
for (int i = 0; i < _creatorProperties.size(); ++i) {
859+
if (_creatorProperties.get(i).getInternalName().equals(prop.getInternalName())) {
860+
_creatorProperties.set(i, prop);
861+
break;
862+
}
863+
}
864+
}
865+
}
861866
}

0 commit comments

Comments
 (0)