Minor term renaming (primary creator -> default creator) in var names, comments (#4739)

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

@@ -656,22 +656,22 @@ protected void _addCreators(Map<String, POJOPropertyBuilder> props)
         List<PotentialCreator> constructors = _collectCreators(_classDef.getConstructors());
         List<PotentialCreator> factories = _collectCreators(_classDef.getFactoryMethods());
 
-        // Then find what is the Primary Constructor (if one exists for type):
+        // Then find what is the Default Constructor (if one exists for type):
         // for Java Records and potentially other types too ("data classes"):
         // Needs to be done early to get implicit names populated
-        final PotentialCreator primary;
+        final PotentialCreator defaultCreator;
         if (_isRecordType) {
-            primary = JDK14Util.findCanonicalRecordConstructor(_config, _classDef, constructors);
+            defaultCreator = JDK14Util.findCanonicalRecordConstructor(_config, _classDef, constructors);
         } else {
-            primary = _annotationIntrospector.findDefaultCreator(_config, _classDef,
+            defaultCreator = _annotationIntrospector.findDefaultCreator(_config, _classDef,
                     constructors, factories);
         }
         // Next: remove creators marked as explicitly disabled
         _removeDisabledCreators(constructors);
         _removeDisabledCreators(factories);
 
         // And then remove non-annotated static methods that do not look like factories
-        _removeNonFactoryStaticMethods(factories, primary);
+        _removeNonFactoryStaticMethods(factories, defaultCreator);
 
         // and use annotations to find explicitly chosen Creators
         if (_useAnnotations) { // can't have explicit ones without Annotation introspection
@@ -686,21 +686,21 @@ protected void _addCreators(Map<String, POJOPropertyBuilder> props)
         // for ones with explicitly-named ({@code @JsonProperty}) parameters
         if (!creators.hasPropertiesBased()) {
             // only discover constructor Creators?
-            _addCreatorsWithAnnotatedNames(creators, constructors, primary);
+            _addCreatorsWithAnnotatedNames(creators, constructors, defaultCreator);
         }
 
         // But if no annotation-based Creators found, find/use Primary Creator
         // detected earlier, if any
-        if (primary != null) {
+        if (defaultCreator != null) {
             if (!creators.hasPropertiesBased()) {
                 // ... but only process if still included as a candidate
-                if (constructors.remove(primary)
-                        || factories.remove(primary)) {
+                if (constructors.remove(defaultCreator)
+                        || factories.remove(defaultCreator)) {
                     // But wait! Could be delegating
-                    if (_isDelegatingConstructor(primary)) {
-                        creators.addExplicitDelegating(primary);
+                    if (_isDelegatingConstructor(defaultCreator)) {
+                        creators.addExplicitDelegating(defaultCreator);
                     } else {
-                        creators.setPropertiesBased(_config, primary, "Primary");
+                        creators.setPropertiesBased(_config, defaultCreator, "Primary");
                     }
                 }
             }
@@ -799,7 +799,7 @@ private void _removeNonVisibleCreators(List<PotentialCreator> ctors)
     }
 
     private void _removeNonFactoryStaticMethods(List<PotentialCreator> ctors,
-            PotentialCreator canonical)
+            PotentialCreator defaultCreator)
     {
         final Class<?> rawType = _type.getRawClass();
         Iterator<PotentialCreator> it = ctors.iterator();
@@ -810,7 +810,7 @@ private void _removeNonFactoryStaticMethods(List<PotentialCreator> ctors,
                 continue;
             }
             // Do not trim canonical either
-            if (canonical == ctor) {
+            if (defaultCreator == ctor) {
                 continue;
             }
             // Copied from `BasicBeanDescription.isFactoryMethod()`