Fix #3022 (in 2.11 for possible 2.11.5)

Author: cowtowncoder

release-notes/CREDITS-2.x

@@ -1168,3 +1168,9 @@ Lucian H (symposion@github)
   * Reported, suggested fix for #2944: `@JsonCreator` on constructor not compatible
     with `@JsonIdentityInfo`, `PropertyGenerator`
   (2.11.4)
+
+Gian Merlino (gianm@github)
+#3022: Property ignorals cause `BeanDeserializer `to forget how to read
+   from arrays (not copying `_arrayDelegateDeserializer`)
+  (2.11.5 / 2.12.2)
+ 

release-notes/VERSION-2.x

@@ -4,6 +4,12 @@ Project: jackson-databind
 === Releases === 
 ------------------------------------------------------------------------
 
+(not yet released)
+
+#3022: Property ignorals cause `BeanDeserializer `to forget how to read
+  from arrays (not copying `_arrayDelegateDeserializer`)
+ (reported by Gian M)
+
 2.11.4 (12-Dec-2020)
 
 #2894: Fix type resolution for static methods (regression in 2.11.3 due to #2821 fix)

src/main/java/com/fasterxml/jackson/databind/deser/BeanDeserializerBase.java

@@ -65,12 +65,18 @@ public abstract class BeanDeserializerBase
     /**
      * Deserializer that is used iff delegate-based creator is
      * to be used for deserializing from JSON Object.
+     *<p>
+     * NOTE: cannot be {@code final} because we need to get it during
+     * {@code resolve()} method (and not contextualization).
      */
     protected JsonDeserializer<Object> _delegateDeserializer;
 
     /**
      * Deserializer that is used iff array-delegate-based creator
      * is to be used for deserializing from JSON Object.
+     *<p>
+     * NOTE: cannot be {@code final} because we need to get it during
+     * {@code resolve()} method (and not contextualization).
      */
     protected JsonDeserializer<Object> _arrayDelegateDeserializer;
 
@@ -204,7 +210,11 @@ protected BeanDeserializerBase(BeanDeserializerBuilder builder,
     {
         super(beanDesc.getType());
         _beanType = beanDesc.getType();
+
         _valueInstantiator = builder.getValueInstantiator();
+        _delegateDeserializer = null;
+        _arrayDelegateDeserializer = null;
+        _propertyBasedCreator = null;
 
         _beanProperties = properties;
         _backRefs = backRefs;
@@ -256,6 +266,7 @@ protected BeanDeserializerBase(BeanDeserializerBase src, boolean ignoreAllUnknow
 
         _valueInstantiator = src._valueInstantiator;
         _delegateDeserializer = src._delegateDeserializer;
+        _arrayDelegateDeserializer = src._arrayDelegateDeserializer;
         _propertyBasedCreator = src._propertyBasedCreator;
 
         _beanProperties = src._beanProperties;
@@ -282,6 +293,7 @@ protected BeanDeserializerBase(BeanDeserializerBase src, NameTransformer unwrapp
 
         _valueInstantiator = src._valueInstantiator;
         _delegateDeserializer = src._delegateDeserializer;
+        _arrayDelegateDeserializer = src._arrayDelegateDeserializer;
         _propertyBasedCreator = src._propertyBasedCreator;
 
         _backRefs = src._backRefs;
@@ -319,6 +331,7 @@ public BeanDeserializerBase(BeanDeserializerBase src, ObjectIdReader oir)
 
         _valueInstantiator = src._valueInstantiator;
         _delegateDeserializer = src._delegateDeserializer;
+        _arrayDelegateDeserializer = src._arrayDelegateDeserializer;
         _propertyBasedCreator = src._propertyBasedCreator;
 
         _backRefs = src._backRefs;
@@ -356,6 +369,7 @@ public BeanDeserializerBase(BeanDeserializerBase src, Set<String> ignorableProps
 
         _valueInstantiator = src._valueInstantiator;
         _delegateDeserializer = src._delegateDeserializer;
+        _arrayDelegateDeserializer = src._arrayDelegateDeserializer;
         _propertyBasedCreator = src._propertyBasedCreator;
 
         _backRefs = src._backRefs;
@@ -387,6 +401,7 @@ protected BeanDeserializerBase(BeanDeserializerBase src, BeanPropertyMap beanPro
 
         _valueInstantiator = src._valueInstantiator;
         _delegateDeserializer = src._delegateDeserializer;
+        _arrayDelegateDeserializer = src._arrayDelegateDeserializer;
         _propertyBasedCreator = src._propertyBasedCreator;
 
         _beanProperties = beanProps;

src/test/java/com/fasterxml/jackson/databind/deser/builder/BuilderSimpleTest.java

@@ -299,8 +299,8 @@ private Value2354 build() {
     @JsonDeserialize(builder = ValidatingValue.Builder.class)
     static class ValidatingValue
     {
-        private final String first;
-        private final String second;
+        final String first;
+        final String second;
 
         ValidatingValue(String first, String second) {
             this.first = first;
@@ -309,6 +309,8 @@ static class ValidatingValue
 
         static class ValidationException extends RuntimeException
         {
+            private static final long serialVersionUID = 1L;
+
             ValidationException(String message) {
                 super(message);
             }

src/test/java/com/fasterxml/jackson/databind/struct/FormatFeatureAcceptSingleTest.java

@@ -60,7 +60,7 @@ static class StringListWrapper {
     static class StringListWrapperWithBuilder {
         public final List<String> values;
 
-        private StringListWrapperWithBuilder(List<String> values) {
+        StringListWrapperWithBuilder(List<String> values) {
             this.values = values;
         }
 
@@ -102,7 +102,7 @@ static class RolesInList {
     static class RolesInListWithBuilder {
         public final List<Role> roles;
 
-        private RolesInListWithBuilder(List<Role> roles) {
+        RolesInListWithBuilder(List<Role> roles) {
             this.roles = roles;
         }
 
@@ -137,7 +137,7 @@ static class Role {
 
     @JsonDeserialize
     static class WrapperWithStringFactory {
-        private final Role role;
+        final Role role;
 
         private WrapperWithStringFactory(Role role) {
             this.role = role;