Fix #1654: handle properties annotated with @JsonTypeInfo(use = NONE) #5467
Conversation
…h @JsonTypeInfo(use = NONE)
|
Minor cleanup: removed extra whitespace in |
| if (_property == null) { | ||
| return true; | ||
| } | ||
| JsonTypeInfo typeInfo = _property.getAnnotation(JsonTypeInfo.class); |
There was a problem hiding this comment.
This is too expensive call to make during actual reading -- that information needs to be gathered when constructing or initializing TypeDeserializer instance.
Also: direct annotation access should be avoided: all access must be through AnnotationIntrospector (to allow for mix-in annotations, support for non-Jackson annotations (like JAXB))
There was a problem hiding this comment.
Thank you for the kind explanation :)
I’ll review the changes you suggested in the PR and update my work accordingly
#5477
src/main/java/tools/jackson/databind/jsontype/impl/TypeSerializerBase.java
Show resolved
Hide resolved
|
@cowtowncoder I’ve taken a look at your more comprehensive approach there, and I fully agree that it’s a better overall direction for fixing #1654 (especially with the dedicated NoOp type (de)serializers and handling in TypeResolverProvider). I’m happy to have this PR closed in favor of #5477 if that makes things simpler. |
2 participants
Issue: #1654
I resolved it.