Skip to content

Commit 006d669

Browse files
JooHyukKimJooHyukKim
committed
Move failing tests
1 parent 5bb7171 commit 006d669

15 files changed

+51
-30
lines changed

‎pom.xml‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -183,21 +183,6 @@ alternative support for serializing POJOs as XML and deserializing XML as pojos.
183183
</execution>
184184
</executions>
185185
</plugin>
186-
<!-- Need to skip known-failing tests for build... -->
187-
<plugin>
188-
<groupId>org.apache.maven.plugins</groupId>
189-
<artifactId>maven-surefire-plugin</artifactId>
190-
<version>${version.plugin.surefire}</version>
191-
<configuration>
192-
<excludes>
193-
<exclude>**/failing/**/*.java</exclude>
194-
</excludes>
195-
<includes>
196-
<include>**/Test*.java</include>
197-
<include>**/*Test.java</include>
198-
</includes>
199-
</configuration>
200-
</plugin>
201186
<!-- 20-Mar-2019, tatu: use Moditect for JDK9+ module info inclusion -->
202187
<plugin>
203188
<groupId>org.moditect</groupId>

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/ConflictingGetters27Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/ConflictingGetters27Test.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import org.junit.jupiter.api.Test;
44

@@ -8,6 +8,7 @@
88
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
99
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
1010
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
11+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
1112

1213
import static org.junit.jupiter.api.Assertions.assertNotNull;
1314

@@ -54,6 +55,7 @@ public BeanInfo() { }
5455
*/
5556

5657
// [dataformat-xml#27]
58+
@JacksonTestFailureExpected
5759
@Test
5860
public void testIssue27() throws Exception
5961
{

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/ElementWrapperViaCreator149Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/ElementWrapperViaCreator149Test.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import java.util.Arrays;
44
import java.util.List;
@@ -12,6 +12,7 @@
1212
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
1313
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
1414
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
15+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
1516

1617
import static org.junit.jupiter.api.Assertions.assertEquals;
1718
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -49,6 +50,7 @@ public Body149(@JacksonXmlProperty(localName="type")
4950
private final ObjectMapper MAPPER = newMapper();
5051

5152
// [dataformat-xml#149]
53+
@JacksonTestFailureExpected
5254
@Test
5355
public void testElementWrapper149() throws Exception
5456
{

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/EnumIssue9Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/EnumIssue9Test.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import org.junit.jupiter.api.Test;
44

55
import com.fasterxml.jackson.annotation.JsonTypeInfo;
66
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
77
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
8+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
89

910
import static org.junit.jupiter.api.Assertions.*;
1011

@@ -32,6 +33,7 @@ public UntypedEnumBean() { }
3233

3334
private final XmlMapper MAPPER = newMapper();
3435

36+
@JacksonTestFailureExpected
3537
@Test
3638
public void testUntypedEnum() throws Exception
3739
{

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/Issue37AdapterTest.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/Issue37AdapterTest.java‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import java.io.UnsupportedEncodingException;
44
import java.net.URLDecoder;
@@ -15,6 +15,7 @@
1515
import com.fasterxml.jackson.databind.AnnotationIntrospector;
1616
import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
1717
import com.fasterxml.jackson.dataformat.xml.*;
18+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
1819

1920
import static org.junit.jupiter.api.Assertions.assertEquals;
2021

@@ -125,6 +126,7 @@ public void setUp() throws Exception
125126
/**********************************************************************
126127
*/
127128

129+
@JacksonTestFailureExpected
128130
@Test
129131
public void testSimpleKeyMap() throws Exception
130132
{
@@ -135,6 +137,7 @@ public void testSimpleKeyMap() throws Exception
135137
_jaxbMapper.writeValueAsString(bean));
136138
}
137139

140+
@JacksonTestFailureExpected
138141
@Test
139142
public void testNeedEncodingKeyMap() throws Exception
140143
{
@@ -147,6 +150,7 @@ public void testNeedEncodingKeyMap() throws Exception
147150
xml);
148151
}
149152

153+
@JacksonTestFailureExpected
150154
@Test
151155
public void testSimpleKeyMapSimpleAnnotation() throws Exception
152156
{
@@ -158,6 +162,7 @@ public void testSimpleKeyMapSimpleAnnotation() throws Exception
158162
_jaxbMapper.writeValueAsString(bean));
159163
}
160164

165+
@JacksonTestFailureExpected
161166
@Test
162167
public void testNeedEncodingKeyMapSimpleAnnotation() throws Exception
163168
{
@@ -169,6 +174,7 @@ public void testNeedEncodingKeyMapSimpleAnnotation() throws Exception
169174
_jaxbMapper.writeValueAsString(bean));
170175
}
171176

177+
@JacksonTestFailureExpected
172178
@Test
173179
public void testNeedEncodingKeyMap_nonJaxb() throws Exception
174180
{
@@ -180,6 +186,7 @@ public void testNeedEncodingKeyMap_nonJaxb() throws Exception
180186
_nonJaxbMapper.writeValueAsString(bean));
181187
}
182188

189+
@JacksonTestFailureExpected
183190
@Test
184191
public void testNeedEncodingKeyMapSimpleAnnotation_nonJaxb() throws Exception
185192
{

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/PojoAsAttributeSer128Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/PojoAsAttributeSer128Test.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import org.junit.jupiter.api.Test;
44

55
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
66
import com.fasterxml.jackson.annotation.JsonRootName;
7-
87
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
98
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
109
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
10+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
1111

1212
import static org.junit.jupiter.api.Assertions.assertEquals;
1313

@@ -39,6 +39,7 @@ static class Container {
3939

4040
private final XmlMapper MAPPER = newMapper();
4141

42+
@JacksonTestFailureExpected
4243
@Test
4344
public void testAttributeDeser128() throws Exception
4445
{

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/PolymorphicIssue4Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/PolymorphicIssue4Test.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import org.junit.jupiter.api.Test;
44

55
import com.fasterxml.jackson.annotation.JsonTypeInfo;
66
import com.fasterxml.jackson.dataformat.xml.XmlMapper;
77
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
8+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
89

910
import static org.junit.jupiter.api.Assertions.assertEquals;
1011
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -76,6 +77,7 @@ public ClassArrayWrapper() { }
7677
*/
7778
// Does not work since array wrapping is not explicitly forced (unlike with collection
7879
// property of a bean
80+
@JacksonTestFailureExpected
7981
@Test
8082
public void testAsClassArray() throws Exception
8183
{
@@ -88,6 +90,7 @@ public void testAsClassArray() throws Exception
8890

8991
// Hmmh. Does not yet quite work either, since we do not properly force
9092
// array context when writing...
93+
@JacksonTestFailureExpected
9194
@Test
9295
public void testAsWrappedClassArray() throws Exception
9396
{

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/PolymorphicList426Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/PolymorphicList426Test.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import java.io.IOException;
44
import java.util.List;
@@ -14,6 +14,7 @@
1414
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
1515
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
1616
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
17+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
1718

1819
import static org.junit.jupiter.api.Assertions.assertEquals;
1920
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -89,6 +90,7 @@ public JsonTypeInfo.Id getMechanism() {
8990
private final ObjectMapper MAPPER = newMapper();
9091

9192
// [dataformat-xml#426]
93+
@JacksonTestFailureExpected
9294
@Test
9395
public void testPolymorphicList426() throws Exception
9496
{

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/PolymorphicList576Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/PolymorphicList576Test.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import java.util.*;
44

@@ -10,6 +10,7 @@
1010

1111
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
1212
import com.fasterxml.jackson.dataformat.xml.annotation.*;
13+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
1314

1415
import static org.junit.jupiter.api.Assertions.assertEquals;
1516

@@ -92,6 +93,7 @@ static class Base {
9293

9394
private final ObjectMapper XML_MAPPER = newMapper();
9495

96+
@JacksonTestFailureExpected
9597
@Test
9698
public void test_3itemsInXml_expect_3itemsInDeserializedObject() throws Exception {
9799
String xmlString =
@@ -106,6 +108,7 @@ public void test_3itemsInXml_expect_3itemsInDeserializedObject() throws Exceptio
106108
assertEquals(3, ((Wrapper)base).getItems().size());
107109
}
108110

111+
@JacksonTestFailureExpected
109112
@Test
110113
public void test_2itemsInObject_expect_2itemsInObjectAfterRoundTripDeserializationToBaseClass() throws Exception {
111114
Wrapper wrapper = new Wrapper();

‎src/test/java/com/fasterxml/jackson/dataformat/xml/failing/TypeInfoOrder525Test.java‎ renamed to ‎src/test/java/com/fasterxml/jackson/dataformat/xml/tofix/TypeInfoOrder525Test.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.dataformat.xml.failing;
1+
package com.fasterxml.jackson.dataformat.xml.tofix;
22

33
import java.util.List;
44

@@ -7,6 +7,7 @@
77
import com.fasterxml.jackson.annotation.*;
88
import com.fasterxml.jackson.databind.ObjectMapper;
99
import com.fasterxml.jackson.dataformat.xml.XmlTestUtil;
10+
import com.fasterxml.jackson.dataformat.xml.testutil.failure.JacksonTestFailureExpected;
1011

1112
import static org.junit.jupiter.api.Assertions.assertEquals;
1213

@@ -46,6 +47,7 @@ static class BindingInfo525 {
4647
.defaultUseWrapper(false)
4748
.build();
4849

50+
@JacksonTestFailureExpected
4951
@Test
5052
public void testTypeAfterOtherProperties() throws Exception {
5153
String xml =

0 commit comments

Comments
 (0)