Skip to content

Commit add9b17

Browse files
committed
Put back comments
1 parent f73afda commit add9b17

24 files changed

+51
-0
lines changed

src/test/java/com/fasterxml/jackson/dataformat/xml/lists/RootListHandlingTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414

1515
import static org.junit.jupiter.api.Assertions.*;
1616

17+
/**
18+
* Tests for verifying that Lists (and arrays) can be serialized even
19+
* when they are root values.
20+
*/
1721
public class RootListHandlingTest extends XmlTestUtil
1822
{
1923
@JsonRootName("SR")

src/test/java/com/fasterxml/jackson/dataformat/xml/lists/StringListRoundtripTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import static java.util.Arrays.asList;
1414
import static org.junit.Assert.*;
1515

16+
// [dataformat-xml#584]
1617
public class StringListRoundtripTest
1718
{
1819
private final static String[] TEST_DATA = new String[] {"", "test", null, "test2"};

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/ArrayConversionsTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313

1414
import static org.junit.jupiter.api.Assertions.*;
1515

16+
/**
17+
* Conversion tests to ensure that standard ObjectMapper conversions
18+
* work despite XmlMapper having to add XML-specific work-arounds.
19+
*/
1620
public class ArrayConversionsTest extends XmlTestUtil
1721
{
1822
static class IntListWrapper {

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/BadEncodingTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
import static org.junit.jupiter.api.Assertions.assertNotNull;
1111

12+
// [dataformat-xml#428]: problem with an encoding supported via JDK
1213
public class BadEncodingTest extends XmlTestUtil
1314
{
1415
// private static final String xml = "<?xml version='1.0' encoding='WINDOWS-1252'?><x/>";

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/CustomAnnotationIntrospectorNoWrapperTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616

1717
import static org.junit.jupiter.api.Assertions.assertEquals;
1818

19+
/**
20+
* A regression test for https://github.com/FasterXML/jackson-databind/issues/4595
21+
*/
1922
public class CustomAnnotationIntrospectorNoWrapperTest extends XmlTestUtil
2023
{
2124
public static class Foo {

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/DTDSupportTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
import static org.junit.jupiter.api.Assertions.fail;
1111

12+
// for [databind-xml#211]
1213
public class DTDSupportTest extends XmlTestUtil
1314
{
1415
@Test

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/ObjectId104Test.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
import static org.junit.jupiter.api.Assertions.assertEquals;
1414
import static org.junit.jupiter.api.Assertions.assertSame;
1515

16+
/**
17+
* Unit test to showcase issue #104, based on TestObjectIdDeserialization unit test in databind package.
18+
*/
1619
public class ObjectId104Test extends XmlTestUtil {
1720
// // Classes for external id from property annotations:
1821

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/RootNameTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
import static org.junit.jupiter.api.Assertions.assertEquals;
1616
import static org.junit.jupiter.api.Assertions.fail;
1717

18+
// NOTE: even tho `@JacksonXmlRootElement` will be deprecated in near
19+
// future (possibly in 2.13) -- to be replaced by `@JsonRootName` -- this
20+
// test will use it to ensure we handle both annotations as expected
1821
public class RootNameTest extends XmlTestUtil
1922
{
2023
static class RootBeanBase

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/RootNameWrapping374Test.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
import static org.junit.jupiter.api.Assertions.assertEquals;
1212
import static org.junit.jupiter.api.Assertions.assertNotNull;
1313

14+
// Test originally for [dataformat-xml#374] but later (2.13)
15+
// for [dataformat-xml#485]
1416
public class RootNameWrapping374Test extends XmlTestUtil
1517
{
1618
@JsonRootName("Root")

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/UnwrappedJsonIdentityConflict286Test.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
import static org.junit.jupiter.api.Assertions.assertEquals;
1313
import static org.junit.jupiter.api.Assertions.assertNotNull;
1414

15+
// for [dataformat-xml#286]: parser getting confused with unwrapped lists,
16+
// object id
1517
public class UnwrappedJsonIdentityConflict286Test extends XmlTestUtil
1618
{
1719
static class Town

0 commit comments

Comments
 (0)