Merge test-jdk17 tests into main post [databind#4820]
#694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| package tools.jackson.dataformat.xml.records.failing; | |||
| package tools.jackson.dataformat.xml.failing; | |||
Member
There was a problem hiding this comment.
Let's keep "records" package to avoid adding stuff at main level. I can rename I think.
Member
There was a problem hiding this comment.
Actually it's failing test, n/m.
Member
Author
There was a problem hiding this comment.
I did change to package tools.jackson.dataformat.xml.failing.records;, but feel free to change other way
| @@ -1,4 +1,4 @@ | |||
| package tools.jackson.dataformat.xml.records.failing; | |||
| package tools.jackson.dataformat.xml.failing.records; | |||
Member
There was a problem hiding this comment.
I'll merge now, it's fine :)
cowtowncoder
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.