Migrate smile module tests to JUnit 5

Author: JooHyukKim

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/BaseTestForSmile.java

@@ -225,7 +225,7 @@ protected String getAndVerifyText(JsonParser p) throws IOException
         if (str.length() !=  actLen) {
             fail("Internal problem (p.token == "+p.getCurrentToken()+"): p.getText().length() ['"+str+"'] == "+str.length()+"; p.getTextLength() == "+actLen);
         }
-        assertEquals("String access via getText(), getTextXxx() must be the same", str, str2);
+        assertEquals(str, str2, "String access via getText(), getTextXxx() must be the same");
 
         return str;
     }

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/async/SimpleStringArrayTest.java

@@ -141,8 +141,8 @@ public void testLongAsciiStringsLowStringLimit() throws IOException
             r.currentText();
             fail("expected StreamConstraintsException");
         } catch (StreamConstraintsException ise) {
-            assertTrue("unexpected exception message: " + ise.getMessage(),
-                    ise.getMessage().startsWith("String value length (98) exceeds the maximum allowed"));
+            assertTrue(ise.getMessage().startsWith("String value length (98) exceeds the maximum allowed"),
+                    "unexpected exception message: " + ise.getMessage());
         }
     }
 

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/gen/TestGeneratorWithRawUtf8.java

@@ -166,20 +166,20 @@ private void doTestIssue492(boolean asUtf8String) throws Exception
         assertToken(parser.nextToken(), JsonToken.START_OBJECT);
 
         assertToken(parser.nextToken(), JsonToken.FIELD_NAME);
-        assertEquals(parser.currentName(), "name");
+        assertEquals("name", parser.currentName());
         assertToken(parser.nextToken(), JsonToken.VALUE_STRING);
-        assertEquals(parser.getText(), "PojoFoo");
+        assertEquals("PojoFoo", parser.getText());
 
         assertToken(parser.nextToken(), JsonToken.FIELD_NAME);
-        assertEquals(parser.currentName(), "collection");
+        assertEquals("collection", parser.currentName());
         assertToken(parser.nextToken(), JsonToken.START_OBJECT);
 
         assertToken(parser.nextToken(), JsonToken.FIELD_NAME);
-        assertEquals("Should have property with name 'v'", parser.currentName(), "v");
+        assertEquals("v", parser.currentName(), "Should have property with name 'v'");
         assertToken(parser.nextToken(), JsonToken.START_ARRAY);
 
         assertToken(parser.nextToken(), JsonToken.VALUE_STRING);
-        assertEquals("Should get String value '1'", parser.getText(), "1");
+        assertEquals("1", parser.getText(), "Should get String value '1'");
 
         assertToken(parser.nextToken(), JsonToken.END_ARRAY);
         assertToken(parser.nextToken(), JsonToken.END_OBJECT);

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/gen/dos/CyclicSmileDataSerTest.java

@@ -10,7 +10,7 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.dataformat.smile.BaseTestForSmile;
 
-import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assertions.*;
 
 public class CyclicSmileDataSerTest extends BaseTestForSmile
 {
@@ -26,8 +26,8 @@ public void testListWithSelfReference() throws Exception {
         } catch (DatabindException e) {
             String exceptionPrefix = String.format("Document nesting depth (%d) exceeds the maximum allowed",
                     StreamWriteConstraints.DEFAULT_MAX_DEPTH + 1);
-            assertTrue("DatabindException message is as expected?",
-                    e.getMessage().startsWith(exceptionPrefix));
+            assertTrue(e.getMessage().startsWith(exceptionPrefix),
+                    "DatabindException message is as expected?");
         }
     }
 }

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/parse/SmileNumberParsingTest.java

@@ -428,8 +428,8 @@ public void testVeryBigDecimal() throws IOException
                 p.getNumberType();
                 fail("expected StreamConstraintsException");
             } catch (StreamConstraintsException nfe) {
-                assertTrue("unexpected exception message: " + nfe.getMessage(),
-                        nfe.getMessage().startsWith("Number value length (4153) exceeds the maximum allowed"));
+                assertTrue(nfe.getMessage().startsWith("Number value length (4153) exceeds the maximum allowed"),
+                        "unexpected exception message: " + nfe.getMessage());
             }
         }
     }

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/parse/dos/DeepNestingSmileParserTest.java

@@ -10,7 +10,7 @@
 import com.fasterxml.jackson.dataformat.smile.BaseTestForSmile;
 import com.fasterxml.jackson.dataformat.smile.SmileFactory;
 
-import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assertions.*;
 
 public class DeepNestingSmileParserTest extends BaseTestForSmile
 {
@@ -28,8 +28,8 @@ public void testDeeplyNestedObjects() throws Exception
         } catch (StreamConstraintsException e) {
             String exceptionPrefix = String.format("Document nesting depth (%d) exceeds the maximum allowed",
                     StreamReadConstraints.DEFAULT_MAX_DEPTH + 1);
-            assertTrue("StreamConstraintsException message is as expected?",
-                    e.getMessage().startsWith(exceptionPrefix));
+            assertTrue(e.getMessage().startsWith(exceptionPrefix),
+                    "StreamConstraintsException message is as expected?");
         }
     }
 
@@ -63,8 +63,8 @@ public void testDeeplyNestedArrays() throws Exception
         } catch (StreamConstraintsException e) {
             String exceptionPrefix = String.format("Document nesting depth (%d) exceeds the maximum allowed",
                     StreamReadConstraints.DEFAULT_MAX_DEPTH + 1);
-            assertTrue("StreamConstraintsException message is as expected?",
-                    e.getMessage().startsWith(exceptionPrefix));
+            assertTrue(e.getMessage().startsWith(exceptionPrefix),
+                    "StreamConstraintsException message is as expected?");
         }
     }
 

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/testutil/PrefixInputDecorator.java

@@ -5,11 +5,10 @@
 
 import com.fasterxml.jackson.core.io.IOContext;
 import com.fasterxml.jackson.core.io.InputDecorator;
-
-@SuppressWarnings("serial")
 import org.junit.jupiter.api.Test;
 import static org.junit.jupiter.api.Assertions.*;
 
+@SuppressWarnings("serial")
 public class PrefixInputDecorator extends InputDecorator
 {
     protected final byte[] _prefix;

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/testutil/PrefixOutputDecorator.java

@@ -4,11 +4,10 @@
 
 import com.fasterxml.jackson.core.io.IOContext;
 import com.fasterxml.jackson.core.io.OutputDecorator;
-
-@SuppressWarnings("serial")
 import org.junit.jupiter.api.Test;
 import static org.junit.jupiter.api.Assertions.*;
 
+@SuppressWarnings("serial")
 public class PrefixOutputDecorator extends OutputDecorator
 {
     protected final byte[] _prefix;

smile/src/test/java/perf/MediaItem.java

@@ -3,9 +3,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import Image;
-
-MediaItem
+public class  MediaItem
 {
      public Media media;
      public List<Image> images;