Skip to content

Commit 57c04f8

Browse files
committed
Post-merge clean up
1 parent a9cc726 commit 57c04f8

File tree

3 files changed

+41
-51
lines changed

3 files changed

+41
-51
lines changed

cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/mapper/NumberBeanTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ static class NestedBigDecimalHolder2784 {
4949
public BigDecimalHolder2784 holder;
5050
}
5151

52+
// for [databind#4917]
5253
static class DeserializationIssue4917 {
5354
public DecimalHolder4917 decimalHolder;
5455
public double number;
@@ -293,5 +294,4 @@ public void testIssue4917() throws Exception {
293294
assertEquals(value.decimalHolder.value, result.decimalHolder.value);
294295
assertEquals(value.number, result.number);
295296
}
296-
297297
}

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/mapper/NumberBeanTest.java

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,13 @@
66

77
import org.junit.jupiter.api.Test;
88

9+
import com.fasterxml.jackson.annotation.JsonCreator;
910
import com.fasterxml.jackson.annotation.JsonUnwrapped;
11+
import com.fasterxml.jackson.annotation.JsonValue;
12+
1013
import com.fasterxml.jackson.core.JsonParser.NumberType;
1114
import com.fasterxml.jackson.core.JsonToken;
15+
1216
import com.fasterxml.jackson.databind.ObjectMapper;
1317
import com.fasterxml.jackson.dataformat.smile.*;
1418

@@ -41,6 +45,26 @@ static class NestedBigDecimalHolder2784 {
4145
public BigDecimalHolder2784 holder;
4246
}
4347

48+
// for [databind#4917]
49+
static class DeserializationIssue4917 {
50+
public DecimalHolder4917 decimalHolder;
51+
public double number;
52+
}
53+
54+
static class DecimalHolder4917 {
55+
@JsonValue
56+
BigDecimal value;
57+
58+
private DecimalHolder4917(BigDecimal value) {
59+
this.value = value;
60+
}
61+
62+
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
63+
static DecimalHolder4917 of(BigDecimal value) {
64+
return new DecimalHolder4917(value);
65+
}
66+
}
67+
4468
/*
4569
/**********************************************************
4670
/* Test methods
@@ -204,4 +228,20 @@ public void testBigDecimalWithBuffering() throws Exception
204228
NestedBigDecimalHolder2784.class);
205229
assertEquals(VALUE, result.holder.value);
206230
}
231+
232+
// [databind#4917]
233+
@Test
234+
public void testIssue4917() throws Exception {
235+
final String bd = "100.00";
236+
final double d = 50.0;
237+
final DeserializationIssue4917 value = new DeserializationIssue4917();
238+
value.decimalHolder = DecimalHolder4917.of(new BigDecimal(bd));
239+
value.number = d;
240+
final byte[] data = MAPPER.writeValueAsBytes(value);
241+
242+
final DeserializationIssue4917 result = MAPPER.readValue(
243+
data, DeserializationIssue4917.class);
244+
assertEquals(value.decimalHolder.value, result.decimalHolder.value);
245+
assertEquals(value.number, result.number);
246+
}
207247
}

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/mapper/NumberReadTest.java

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)