Fix #497: add override for IonValueMapper.copy() (#498)

Author: cowtowncoder

ion/src/main/java/com/fasterxml/jackson/dataformat/ion/ionvalue/IonValueMapper.java

@@ -16,6 +16,7 @@
 
 import java.io.IOException;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.PropertyNamingStrategy;
 import com.fasterxml.jackson.dataformat.ion.EnumAsIonSymbolModule;
 import com.fasterxml.jackson.dataformat.ion.IonFactory;
@@ -45,6 +46,11 @@ public IonValueMapper(IonSystem ionSystem) {
         this(ionSystem, null);
     }
 
+    // @since 2.18: needed for `copy()`
+    protected IonValueMapper(IonValueMapper src) {
+        super(src);
+    }
+
     /**
      * Constructor that provides an override on the default Constructor for the PropertyNamingStrategy.
      *
@@ -60,6 +66,12 @@ public IonValueMapper(IonSystem ionSystem, PropertyNamingStrategy strategy) {
         this.setPropertyNamingStrategy(strategy);
     }
 
+    @Override // @since 2.18
+    public ObjectMapper copy() {
+        _checkInvalidCopy(IonValueMapper.class);
+        return new IonValueMapper(this);
+    }
+    
     public <T> T parse(IonValue value, Class<T> clazz) throws IOException {
         if (value == null) {
             return null;

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/DataBindReadTest.java

@@ -19,7 +19,7 @@
 import org.junit.Test;
 
 import com.fasterxml.jackson.annotation.JsonIgnore;
-
+import com.fasterxml.jackson.databind.ObjectMapper;
 import com.amazon.ion.IonReader;
 import com.amazon.ion.IonStruct;
 import com.amazon.ion.IonSystem;
@@ -39,6 +39,15 @@ static class MyBean {
 
     static class BeanToo { }
 
+    // Not the best place for test but will have to do
+    @Test
+    public void testMapperCopy() throws IOException
+    {
+        IonObjectMapper vanilla = IonObjectMapper.builder().build();
+        ObjectMapper copy = vanilla.copy();
+        assertNotSame(vanilla, copy);
+    }
+
     @Test
     public void testSimple() throws IOException
     {

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/ionvalue/IonValueMapperTest.java

@@ -17,6 +17,7 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNotSame;
 import static org.junit.Assert.assertNull;
 
 import java.io.IOException;
@@ -32,6 +33,7 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 
 import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.PropertyNamingStrategies;
 import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 import com.fasterxml.jackson.dataformat.ion.IonSymbolSerializer;
@@ -67,6 +69,12 @@ public static class TestPojo1 {
         public Timestamp someTime;
     }
 
+    @Test
+    public void testMapperCopy() throws Exception {
+        ObjectMapper mapper2 = ionValueMapper.copy();
+        assertNotSame(ionValueMapper, mapper2);
+    }
+
     @Test
     public void testNull() throws Exception {
         assertNull(ionValueMapper.parse(null, TestPojo1.class));

release-notes/VERSION-2.x

@@ -18,6 +18,11 @@ Active maintainers:
 
 - No changes since 2.17
 
+2.17.2 (not yet released)
+
+#497: (ion) Failed copy(): `IonValueMapper` does not override copy()
+ (reported by @mr-robert)
+
 2.17.1 (04-May-2024)
 
 #487 (ion): Don't close IonParser on EOF to be compatible with `MappingIterator`