Fix misorderd assertions

Author: JooHyukKim

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/DataBindRoundtripTest.java

@@ -146,7 +146,7 @@ public void testIonRoot() throws IOException {
 
         Bean bean = m.readValue(root, Bean.class);
         assertNotNull(bean);
-        assertEquals(bean.a, "test");
+        assertEquals("test", bean.a);
         assertEquals(0.25, bean.b, 0.0);
         assertArrayEquals(new byte[0], bean.data);
         assertTrue(bean.state);

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/PolymorphicRoundtripTest.java

@@ -79,7 +79,7 @@ public void testSubclass() throws IOException {
 
         assertEquals(original.field, deserialized.field);
         assertEquals(original.child.someField, deserialized.child.someField);
-        assertTrue(deserialized.child instanceof ChildBeanSub);
+        assertInstanceOf(ChildBeanSub.class, deserialized.child);
         assertEquals(((ChildBeanSub) original.child).extraField, ((ChildBeanSub) deserialized.child).extraField);
     }
 
@@ -92,7 +92,7 @@ public void testTopLevelPolymorphism() throws IOException {
         mapper.registerModule(new IonAnnotationModule());
         String serialized = mapper.writeValueAsString(original);
         Object obj = mapper.readValue(serialized, Object.class);
-        assertTrue(obj instanceof Bean);
+        assertInstanceOf(Bean.class, obj);
         Bean deserialized = (Bean) obj;
         assertEquals(original.field, deserialized.field);
         assertEquals(original.child.someField, deserialized.child.someField);
@@ -112,14 +112,14 @@ public void testSelectivePolymorphism() throws IOException {
         // to be chosen (and we expect that first id to be the most narrow type, ChildBeanSub).
         Bean deserialized = mapper.readValue(serialized, Bean.class);
 
-        assertEquals(deserialized.child.getClass(), ChildBeanSub.class);
+        assertEquals(ChildBeanSub.class, deserialized.child.getClass());
         assertEquals(((ChildBeanSub) original.child).extraField, ((ChildBeanSub) deserialized.child).extraField);
 
         // second, try deserializing with the wider type (ChildBean). We're losing data (extraField)
         preferredTypeId = getClass().getCanonicalName() + "$ChildBean";
         deserialized = mapper.readValue(serialized, Bean.class);
 
-        assertEquals(deserialized.child.getClass(), ChildBean.class);
+        assertEquals(ChildBean.class, deserialized.child.getClass());
         assertEquals(original.child.someField, deserialized.child.someField);
 
         // third, try deserializing into an Object. The child node should deserialize, but immediately fail mapping.

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/jsr310/IonTimestampInstantDeserializerTest.java

@@ -62,7 +62,7 @@ public void testDeserializationAsFloat03() throws Exception {
     public void testDeserializationAsFloatEdgeCase01() throws Exception {
         String input = Instant.MAX.getEpochSecond() + ".999999999";
         Instant actual = READER.readValue(input);
-        assertEquals(actual, Instant.MAX);
+        assertEquals(Instant.MAX, actual);
         assertEquals(Instant.MAX.getEpochSecond(), actual.getEpochSecond());
         assertEquals(999999999, actual.getNano());
     }
@@ -74,7 +74,7 @@ public void testDeserializationAsFloatEdgeCase01() throws Exception {
     public void testDeserializationAsFloatEdgeCase02() throws Exception {
         String input = Instant.MIN.getEpochSecond() + ".0";
         Instant actual = READER.readValue(input);
-        assertEquals(actual, Instant.MIN);
+        assertEquals(Instant.MIN, actual);
         assertEquals(Instant.MIN.getEpochSecond(), actual.getEpochSecond());
         assertEquals(0, actual.getNano());
     }

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/polymorphism/PolymorphicTypeAnnotationsTest.java

@@ -12,8 +12,7 @@
 import com.fasterxml.jackson.dataformat.ion.IonObjectMapper;
 import com.fasterxml.jackson.dataformat.ion.IonParser.Feature;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.*;
 
 public class PolymorphicTypeAnnotationsTest {
     private static final String SUBCLASS_TYPE_NAME = "subtype";
@@ -56,7 +55,7 @@ public void testNativeTypeIdsDisabledReadsTypeAnnotationsSuccessfully() throws I
 
         Container containerWithBaseClass = mapper.readValue(CONTAINER_WITH_TYPED_OBJECT, Container.class);
 
-        assertTrue(containerWithBaseClass.objectWithType instanceof Subclass);
+        assertInstanceOf(Subclass.class, containerWithBaseClass.objectWithType);
         assertEquals(SUBCLASS_TYPE_NAME, ((Subclass) containerWithBaseClass.objectWithType).base);
     }