support deep nesting check - smile format (#362)

Author: pjfanning

smile/src/main/java/com/fasterxml/jackson/dataformat/smile/SmileParser.java

@@ -529,7 +529,7 @@ public JsonToken nextToken() throws IOException
                 }
                 return _handleSharedString(((ch & 0x3) << 8) + (_inputBuffer[_inputPtr++] & 0xFF));
             case 0x18: // START_ARRAY
-                _streamReadContext = _streamReadContext.createChildArrayContext(-1, -1);
+                createChildArrayContext(-1, -1);
                 return (_currToken = JsonToken.START_ARRAY);
             case 0x19: // END_ARRAY
                 if (!_streamReadContext.inArray()) {
@@ -538,7 +538,7 @@ public JsonToken nextToken() throws IOException
                 _streamReadContext = _streamReadContext.getParent();
                 return (_currToken = JsonToken.END_ARRAY);
             case 0x1A: // START_OBJECT
-                _streamReadContext = _streamReadContext.createChildObjectContext(-1, -1);
+                createChildObjectContext(-1, -1);
                 return (_currToken = JsonToken.START_OBJECT);
             case 0x1B: // not used in this mode; would be END_OBJECT
                 _reportError("Invalid type marker byte 0xFB in value mode (would be END_OBJECT in key mode)");
@@ -3116,5 +3116,15 @@ private final JsonToken _eofAsNextToken() throws IOException {
         close();
         return (_currToken = null);
     }
+
+    private void createChildArrayContext(final int lineNr, final int colNr) throws IOException {
+        _streamReadContext = _streamReadContext.createChildArrayContext(lineNr, colNr);
+        streamReadConstraints().validateNestingDepth(_streamReadContext.getNestingDepth());
+    }
+
+    private void createChildObjectContext(final int lineNr, final int colNr) throws IOException {
+        _streamReadContext = _streamReadContext.createChildObjectContext(lineNr, colNr);
+        streamReadConstraints().validateNestingDepth(_streamReadContext.getNestingDepth());
+    }
 }
 

smile/src/test/java/com/fasterxml/jackson/dataformat/smile/parse/dos/DeepNestingParserTest.java

@@ -0,0 +1,110 @@
+package com.fasterxml.jackson.dataformat.smile.parse.dos;
+
+import com.fasterxml.jackson.core.JsonGenerator;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.JsonToken;
+import com.fasterxml.jackson.core.StreamReadConstraints;
+import com.fasterxml.jackson.core.exc.StreamConstraintsException;
+import com.fasterxml.jackson.dataformat.smile.BaseTestForSmile;
+import com.fasterxml.jackson.dataformat.smile.SmileFactory;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+
+/**
+ * Unit tests for deeply nested JSON
+ */
+public class DeepNestingParserTest extends BaseTestForSmile
+{
+    public void testDeeplyNestedObjects() throws Exception
+    {
+        final int depth = 1500;
+        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        genDeepDoc(out, depth);
+        try (JsonParser jp = _smileParser(out.toByteArray())) {
+            JsonToken jt;
+            while ((jt = jp.nextToken()) != null) {
+
+            }
+            fail("expected StreamConstraintsException");
+        } catch (StreamConstraintsException e) {
+            assertEquals("Depth (1001) exceeds the maximum allowed nesting depth (1000)", e.getMessage());
+        }
+    }
+
+    public void testDeeplyNestedObjectsWithUnconstrainedMapper() throws Exception
+    {
+        final int depth = 1500;
+        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        genDeepDoc(out, depth);
+        SmileFactory smileFactory = SmileFactory.builder()
+                .streamReadConstraints(StreamReadConstraints.builder().maxNestingDepth(Integer.MAX_VALUE).build())
+                .build();
+        try (JsonParser jp = _smileParser(smileFactory, out.toByteArray())) {
+            JsonToken jt;
+            while ((jt = jp.nextToken()) != null) {
+
+            }
+        }
+    }
+
+    public void testDeeplyNestedArrays() throws Exception
+    {
+        final int depth = 750;
+        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        genDeepArrayDoc(out, depth);
+        try (JsonParser jp = _smileParser(out.toByteArray())) {
+            JsonToken jt;
+            while ((jt = jp.nextToken()) != null) {
+
+            }
+            fail("expected StreamConstraintsException");
+        } catch (StreamConstraintsException e) {
+            assertEquals("Depth (1001) exceeds the maximum allowed nesting depth (1000)", e.getMessage());
+        }
+    }
+
+    public void testDeeplyNestedArraysWithUnconstrainedMapper() throws Exception
+    {
+        final int depth = 750;
+        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        genDeepArrayDoc(out, depth);
+        SmileFactory smileFactory = SmileFactory.builder()
+                .streamReadConstraints(StreamReadConstraints.builder().maxNestingDepth(Integer.MAX_VALUE).build())
+                .build();
+        try (JsonParser jp = _smileParser(smileFactory, out.toByteArray())) {
+            JsonToken jt;
+            while ((jt = jp.nextToken()) != null) {
+
+            }
+        }
+    }
+
+    private void genDeepDoc(final ByteArrayOutputStream out, final int depth) throws IOException {
+        try (JsonGenerator gen = smileGenerator(out, true)) {
+            for (int i = 0; i < depth; i++) {
+                gen.writeStartObject();
+                gen.writeFieldName("a");
+            }
+            gen.writeString("val");
+            for (int i = 0; i < depth; i++) {
+                gen.writeEndObject();
+            }
+        }
+    }
+
+    private void genDeepArrayDoc(final ByteArrayOutputStream out, final int depth) throws IOException {
+        try (JsonGenerator gen = smileGenerator(out, true)) {
+            for (int i = 0; i < depth; i++) {
+                gen.writeStartObject();
+                gen.writeFieldName("a");
+                gen.writeStartArray();
+            }
+            gen.writeString("val");
+            for (int i = 0; i < depth; i++) {
+                gen.writeEndArray();
+                gen.writeEndObject();
+            }
+        }
+    }
+}