Skip to content

Commit c7f91fb

Browse files
committed
Manual merge of #555 changes to master (pom.xml's won't auto-merge)
1 parent 30eb48e commit c7f91fb

File tree

4 files changed

+21
-14
lines changed

4 files changed

+21
-14
lines changed

avro/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,15 @@ abstractions.
6363
<artifactId>assertj-core</artifactId>
6464
<scope>test</scope>
6565
</dependency>
66+
67+
<!-- 14-Jan-2025, joohyukkim: [JSTEP-10] Most tests have been migrated to
68+
JUnit5, but except `avro` modules `/interop` tests
69+
-->
70+
<dependency>
71+
<groupId>junit</groupId>
72+
<artifactId>junit</artifactId>
73+
<scope>test</scope>
74+
</dependency>
6675
</dependencies>
6776

6877
<build>

ion/src/test/java/tools/jackson/dataformat/ion/PrettyPrintWriteTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package tools.jackson.dataformat.ion;
22

3-
import org.junit.Assert;
4-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
54

65
import com.fasterxml.jackson.annotation.JsonPropertyOrder;
76

87
import tools.jackson.databind.SerializationFeature;
98

9+
import static org.junit.jupiter.api.Assertions.assertEquals;
10+
import static org.junit.jupiter.api.Assertions.assertNotNull;
11+
1012
// For [dataformats-binary#245]: no pretty-printing for textual format
1113
public class PrettyPrintWriteTest
1214
{
@@ -24,17 +26,17 @@ public void testBasicPrettyPrintTextual() throws Exception
2426
IonObjectMapper mapper = IonObjectMapper.builder(IonFactory.forTextualWriters()).build();
2527
String ion = mapper.writerWithDefaultPrettyPrinter()
2628
.writeValueAsString(new Point());
27-
Assert.assertEquals(EXP, ion.trim());
29+
assertEquals(EXP, ion.trim());
2830

2931
ion = mapper.writer()
3032
.with(SerializationFeature.INDENT_OUTPUT)
3133
.writeValueAsString(new Point());
32-
Assert.assertEquals(EXP, ion.trim());
34+
assertEquals(EXP, ion.trim());
3335

3436
// But also no indentation if not requested
3537
ion = mapper.writer()
3638
.writeValueAsString(new Point());
37-
Assert.assertEquals("{x:1,y:2}", ion.trim());
39+
assertEquals("{x:1,y:2}", ion.trim());
3840
}
3941

4042
// and with binary format, should simply be no-op
@@ -43,6 +45,6 @@ public void testIgnorePrettyPrintForBinary() throws Exception
4345
{
4446
IonObjectMapper mapper = IonObjectMapper.builder(IonFactory.forBinaryWriters()).build();
4547
byte[] encoded = mapper.writerWithDefaultPrettyPrinter().writeValueAsBytes(new Point());
46-
Assert.assertNotNull(encoded);
48+
assertNotNull(encoded);
4749
}
4850
}

ion/src/test/java/tools/jackson/dataformat/ion/SimpleIonReadTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@
1616

1717
import java.io.*;
1818

19-
import org.junit.Test;
20-
import static org.junit.Assert.*;
19+
import org.junit.jupiter.api.Test;
2120

2221
import tools.jackson.core.JsonParser;
2322
import tools.jackson.core.JsonToken;
2423

24+
import static org.junit.jupiter.api.Assertions.assertEquals;
25+
import static org.junit.jupiter.api.Assertions.assertNull;
26+
2527
public class SimpleIonReadTest {
2628
private final IonObjectMapper MAPPER = new IonObjectMapper();
2729

pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,6 @@
6363
<artifactId>jackson-core</artifactId>
6464
</dependency>
6565

66-
<!-- 20-Apr-2024, tatu: JUnit4 no longer from jackson-base, so: -->
67-
<dependency>
68-
<groupId>junit</groupId>
69-
<artifactId>junit</artifactId>
70-
<scope>test</scope>
71-
</dependency>
7266
<!-- 11-Jan-2025, joohyukkim: For JSTEP-10, migrate to JUnit5 -->
7367
<dependency>
7468
<groupId>org.junit.jupiter</groupId>

0 commit comments

Comments
 (0)