Merge branch '2.17' of github.com:FasterXML/jackson-dataformats-binary into 2.17

Author: cowtowncoder

ion/src/main/java/com/fasterxml/jackson/dataformat/ion/IonParser.java

@@ -369,6 +369,9 @@ private double _getDoubleValue() throws IOException {
     @Override
     public float getFloatValue() throws IOException {
         _verifyIsNumberToken();
+        // 04-May-2024, tatu: May seem odd but Ion really does not
+        //   expose 32-bit floats even if it MAY use them internally
+        //   for encoding. So:
         return (float) _getDoubleValue();
     }
 
@@ -472,6 +475,7 @@ public NumberType getNumberType() throws IOException
                         return NumberType.BIG_INTEGER;
                     }
                 case FLOAT:
+                    // 04-May-2024, tatu: Ion really does not expose 32-bit floats, so:
                     return NumberType.DOUBLE;
                 default:
                 }
@@ -489,7 +493,9 @@ public NumberTypeFP getNumberTypeFP() throws IOException
                 // 06-Jan-2024, tatu: Existing code maps Ion `FLOAT` into Java
                 //    `float`. But code in `IonReader` suggests `Double` might
                 //    be more accurate mapping... odd.
-                return NumberTypeFP.FLOAT32;
+                // 04-May-2024, tatu: Ion really does not expose 32-bit floats;
+                //    must expose as 64-bit here too
+                return NumberTypeFP.DOUBLE64;
             }
             if (type == IonType.DECIMAL) {
                 // 06-Jan-2024, tatu: Seems like `DECIMAL` is expected to map

ion/src/test/java/com/fasterxml/jackson/dataformat/ion/IonParserTest.java

@@ -75,7 +75,8 @@ public void testGetNumberTypeAndValue() throws Exception {
         IonParser floatParser = new IonFactory().createParser(ionFloat);
         Assert.assertEquals(JsonToken.VALUE_NUMBER_FLOAT, floatParser.nextToken());
         Assert.assertEquals(JsonParser.NumberType.DOUBLE, floatParser.getNumberType());
-        Assert.assertEquals(JsonParser.NumberTypeFP.FLOAT32, floatParser.getNumberTypeFP());
+        // [dataformats-binary#490]: float coerces to double
+        Assert.assertEquals(JsonParser.NumberTypeFP.DOUBLE64, floatParser.getNumberTypeFP());
         Assert.assertEquals(floatValue, floatParser.getNumberValue());
 
         BigDecimal bigDecimalValue = new BigDecimal(Double.MAX_VALUE + "1");

release-notes/VERSION-2.x

@@ -23,8 +23,9 @@ Active maintainers:
 #487 (ion): Don't close IonParser on EOF to be compatible with `MappingIterator`
   when source is an empty `InputStream`
  (contributed by Yoann V)
-
 #488 (ion): Upgrade `ion-java` to 1.11.7 (from 1.11.2)
+#490 (ion) ION deserialization type change from Double to Float in 2.17.0
+ (reported by Florian H)
 
 2.17.0 (12-Mar-2024)