Skip to content

Commit d930a12

Browse files
authored
getColumnDesc returns unpaired square bracket when columns are empty (#283)
1 parent 3a30855 commit d930a12

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1456,10 +1456,9 @@ public Column column(String name, int probableIndex) {
14561456
public String getColumnDesc()
14571457
{
14581458
StringBuilder sb = new StringBuilder(100);
1459+
sb.append('[');
14591460
for (Column col : _columns) {
1460-
if (sb.length() == 0) {
1461-
sb.append('[');
1462-
} else {
1461+
if (sb.length() > 1) {
14631462
sb.append(',');
14641463
}
14651464
sb.append('"');

csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,12 @@ public void testReorderWithComparator() throws Exception
142142
_verifyLinks(schema);
143143
}
144144

145+
public void testColumnDescForEmptyScheme() throws Exception
146+
{
147+
CsvSchema schema = CsvSchema.emptySchema();
148+
assertEquals("[]", schema.getColumnDesc());
149+
}
150+
145151
private void _verifyLinks(CsvSchema schema)
146152
{
147153
List<Column> all = new ArrayList<Column>();

0 commit comments

Comments
 (0)