Skip to content

Commit e187ee2

Browse files
committed
Fix h5 LazyLoadingTest
1 parent 94fb7cd commit e187ee2

File tree

3 files changed

+5
-17
lines changed

3 files changed

+5
-17
lines changed

hibernate4/src/main/java/tools/jackson/datatype/hibernate4/HibernateProxySerializer.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,7 @@
88
import javax.persistence.EntityNotFoundException;
99

1010
import tools.jackson.core.*;
11-
import tools.jackson.databind.BeanProperty;
12-
import tools.jackson.databind.JavaType;
13-
import tools.jackson.databind.DatabindException;
14-
import tools.jackson.databind.ValueSerializer;
15-
import tools.jackson.databind.SerializationContext;
11+
import tools.jackson.databind.*;
1612
import tools.jackson.databind.jsonFormatVisitors.JsonFormatVisitorWrapper;
1713
import tools.jackson.databind.jsontype.TypeSerializer;
1814
import tools.jackson.databind.ser.impl.PropertySerializerMap;
@@ -231,7 +227,6 @@ protected ValueSerializer<Object> findSerializer(SerializationContext provider,
231227
*/
232228
PropertySerializerMap.SerializerAndMapResult result =
233229
_dynamicSerializers.findAndAddPrimarySerializer(
234-
//TODO find better way to get JavaType
235230
provider.constructType(type),
236231
provider,
237232
_property);

hibernate5/src/main/java/tools/jackson/datatype/hibernate5/HibernateProxySerializer.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,10 @@
88
import javax.persistence.EntityNotFoundException;
99

1010
import tools.jackson.core.JsonGenerator;
11-
import tools.jackson.databind.BeanProperty;
12-
import tools.jackson.databind.JavaType;
13-
import tools.jackson.databind.DatabindException;
14-
import tools.jackson.databind.ValueSerializer;
15-
import tools.jackson.databind.SerializationContext;
11+
import tools.jackson.databind.*;
1612
import tools.jackson.databind.jsonFormatVisitors.JsonFormatVisitorWrapper;
1713
import tools.jackson.databind.jsontype.TypeSerializer;
1814
import tools.jackson.databind.ser.impl.PropertySerializerMap;
19-
import tools.jackson.databind.type.TypeFactory;
2015
import tools.jackson.databind.util.NameTransformer;
2116

2217
import org.hibernate.engine.spi.Mapping;
@@ -233,8 +228,7 @@ protected ValueSerializer<Object> findSerializer(SerializationContext provider,
233228
*/
234229
PropertySerializerMap.SerializerAndMapResult result =
235230
_dynamicSerializers.findAndAddPrimarySerializer(
236-
//TODO find better way to get JavaType
237-
TypeFactory.createDefaultInstance().unsafeSimpleType(type),
231+
provider.constructType(type),
238232
provider,
239233
_property);
240234
if (_dynamicSerializers != result.map) {

hibernate5/src/test/java/tools/jackson/datatype/hibernate5/LazyLoadingTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import java.util.*;
44

5+
import org.junit.jupiter.api.Test;
6+
57
import javax.persistence.EntityManager;
68
import javax.persistence.EntityManagerFactory;
79
import javax.persistence.Persistence;
@@ -14,8 +16,6 @@
1416
import tools.jackson.datatype.hibernate5.data.Payment;
1517

1618
import org.hibernate.Hibernate;
17-
import org.junit.jupiter.api.Disabled;
18-
import org.junit.jupiter.api.Test;
1919

2020
import static org.junit.jupiter.api.Assertions.*;
2121

@@ -64,7 +64,6 @@ public void testGetCustomerJson() throws Exception
6464
}
6565
}
6666

67-
@Disabled // https://github.com/FasterXML/jackson-datatype-hibernate/issues/191
6867
@Test
6968
public void testSerializeIdentifierFeature() throws JacksonException {
7069
Hibernate5Module module = new Hibernate5Module();

0 commit comments

Comments
 (0)