Allow users of the api to pass in a custom formatter to the LocalTimeSerializer/Deserializer.

Author: iainCFX

src/main/java/com/fasterxml/jackson/datatype/jsr310/deser/LocalTimeDeserializer.java

@@ -42,13 +42,13 @@ private LocalTimeDeserializer() {
         this(DateTimeFormatter.ISO_LOCAL_TIME);
     }
 
-    protected LocalTimeDeserializer(DateTimeFormatter dtf) {
-        super(LocalTime.class, dtf);
+    public LocalTimeDeserializer(DateTimeFormatter formatter) {
+        super(LocalTime.class, formatter);
     }
 
     @Override
-    protected JsonDeserializer<LocalTime> withDateFormat(DateTimeFormatter dtf) {
-        return new LocalTimeDeserializer(dtf);
+    protected JsonDeserializer<LocalTime> withDateFormat(DateTimeFormatter formatter) {
+        return new LocalTimeDeserializer(formatter);
     }
 
     @Override

src/main/java/com/fasterxml/jackson/datatype/jsr310/ser/LocalTimeSerializer.java

@@ -38,12 +38,15 @@ public class LocalTimeSerializer extends JSR310FormattedSerializerBase<LocalTime
     public static final LocalTimeSerializer INSTANCE = new LocalTimeSerializer();
 
     protected LocalTimeSerializer() {
-        super(LocalTime.class);
+        this(null);
     }
 
-    protected LocalTimeSerializer(LocalTimeSerializer base,
-            Boolean useTimestamp, DateTimeFormatter dtf) {
-        super(base, useTimestamp, dtf);
+    public LocalTimeSerializer(DateTimeFormatter formatter) {
+        super(LocalTime.class, formatter);
+    }
+
+    protected LocalTimeSerializer(LocalTimeSerializer base, Boolean useTimestamp, DateTimeFormatter formatter) {
+        super(base, useTimestamp, formatter);
     }
 
     @Override

src/test/java/com/fasterxml/jackson/datatype/jsr310/TestLocalDateSerializationWithCustomFormatter.java

@@ -29,7 +29,7 @@ public TestLocalDateSerializationWithCustomFormatter(DateTimeFormatter formatter
     @Test
     public void testSerialization() throws Exception {
         LocalDate date = LocalDate.now();
-        assertThat("Failed to serialize with " + formatter, serializeWith(date, formatter), containsString(date.format(formatter)));
+        assertThat(serializeWith(date, formatter), containsString(date.format(formatter)));
     }
 
     private String serializeWith(LocalDate date, DateTimeFormatter formatter) throws Exception {

src/test/java/com/fasterxml/jackson/datatype/jsr310/TestLocalDateTimeSerializationWithCustomFormatter.java

@@ -33,7 +33,7 @@ public TestLocalDateTimeSerializationWithCustomFormatter(DateTimeFormatter forma
     @Test
     public void testSerialization() throws Exception {
         LocalDateTime dateTime = LocalDateTime.now();
-        assertThat("Failed to serialize with " + formatter, serializeWith(dateTime, formatter), containsString(dateTime.format(formatter)));
+        assertThat(serializeWith(dateTime, formatter), containsString(dateTime.format(formatter)));
     }
 
     private String serializeWith(LocalDateTime dateTime, DateTimeFormatter formatter) throws Exception {

src/test/java/com/fasterxml/jackson/datatype/jsr310/TestLocalTimeSerializationWithCustomFormatter.java

@@ -0,0 +1,59 @@
+package com.fasterxml.jackson.datatype.jsr310;
+
+import static org.hamcrest.core.IsEqual.equalTo;
+import static org.junit.Assert.assertThat;
+import static org.junit.internal.matchers.StringContains.containsString;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import com.fasterxml.jackson.datatype.jsr310.deser.LocalTimeDeserializer;
+import com.fasterxml.jackson.datatype.jsr310.ser.LocalTimeSerializer;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
+
+import java.time.LocalTime;
+import java.time.format.DateTimeFormatter;
+import java.time.format.FormatStyle;
+import java.util.ArrayList;
+import java.util.Collection;
+
+@RunWith(Parameterized.class)
+public class TestLocalTimeSerializationWithCustomFormatter {
+    private final DateTimeFormatter formatter;
+
+    public TestLocalTimeSerializationWithCustomFormatter(DateTimeFormatter formatter) {
+        this.formatter = formatter;
+    }
+
+    @Test
+    public void testSerialization() throws Exception {
+        LocalTime dateTime = LocalTime.now();
+        assertThat(serializeWith(dateTime, formatter), containsString(dateTime.format(formatter)));
+    }
+
+    private String serializeWith(LocalTime dateTime, DateTimeFormatter formatter) throws Exception {
+        ObjectMapper mapper = new ObjectMapper().registerModule(new SimpleModule().addSerializer(new LocalTimeSerializer(formatter)));
+        return mapper.writeValueAsString(dateTime);
+    }
+
+    @Test
+    public void testDeserialization() throws Exception {
+        LocalTime dateTime = LocalTime.now();
+        assertThat(deserializeWith(dateTime.format(formatter), formatter), equalTo(dateTime));
+    }
+
+    private LocalTime deserializeWith(String json, DateTimeFormatter formatter) throws Exception {
+        ObjectMapper mapper = new ObjectMapper().registerModule(new SimpleModule().addDeserializer(LocalTime.class, new LocalTimeDeserializer(formatter)));
+        return mapper.readValue("\"" + json + "\"", LocalTime.class);
+    }
+
+    @Parameters
+    public static Collection<Object[]> customFormatters() {
+        Collection<Object[]> formatters = new ArrayList<>();
+        formatters.add(new Object[]{DateTimeFormatter.ISO_LOCAL_TIME});
+        formatters.add(new Object[]{DateTimeFormatter.ISO_TIME});
+        return formatters;
+    }
+}