Update JsonSchema.java

cernautan · web-flow · commit 14e5ff88ad92 · 2021-12-19T02:28:37.000+02:00
I think the protected boolean _equals(JsonSchema that) contains an issue on the 'id' comparison line. It should be equals(getId(), that.getId()) instead of the current code that is  equals(getId(), getId()).
diff --git a/src/main/java/com/fasterxml/jackson/module/jsonSchema/JsonSchema.java b/src/main/java/com/fasterxml/jackson/module/jsonSchema/JsonSchema.java
@@ -518,7 +518,7 @@ public boolean equals(Object obj)
 
     protected boolean _equals(JsonSchema that)
     {
-        return equals(getId(), getId())
+        return equals(getId(), that.getId())
                  // 27-Apr-2015, tatu: Should not need to check type explicitly
  //                 && equals(getType(), getType())
                 && equals(getRequired(), that.getRequired())

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,7 @@ public boolean equals(Object obj)`
`518`	`518`
`519`	`519`	`protected boolean _equals(JsonSchema that)`
`520`	`520`	`{`
`521`		`- return equals(getId(), getId())`
	`521`	`+ return equals(getId(), that.getId())`
`522`	`522`	`// 27-Apr-2015, tatu: Should not need to check type explicitly`
`523`	`523`	`// && equals(getType(), getType())`
`524`	`524`	`&& equals(getRequired(), that.getRequired())`