fixed id comparison in _equals #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the protected boolean _equals(JsonSchema that) contains an issue on the 'id' comparison line. It should be equals(getId(), that.getId()) instead of the current code that is equals(getId(), getId()).
|
Looks like a legit fix, will merge. Would be great to have a unit test to verify but implementation looks wrong so... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the protected boolean _equals(JsonSchema that) contains an issue on the 'id' comparison line. It should be equals(getId(), that.getId()) instead of the current code that is equals(getId(), getId()).