Fix & silence warnings

Author: dinomite

src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinAnnotationIntrospector.kt

@@ -145,6 +145,7 @@ internal class KotlinAnnotationIntrospector(private val context: Module.SetupCon
                 it.getter.javaMethod == this.member
             }
 
+    @Suppress("UNCHECKED_CAST")
     private fun AnnotatedMethod.getCorrespondingSetter(): KMutableProperty1.Setter<out Any, Any?>? {
         val mutableProperty = member.declaringClass.kotlin.declaredMemberProperties.find {
             when (it) {

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/PropertyRequirednessTests.kt

@@ -14,6 +14,7 @@ class TestPropertyRequiredness {
 
     private data class TestParamClass(val foo: String = "bar")
 
+    @Suppress("UNUSED_PARAMETER")
     private class TestClass {
         fun setA(value: Int): Unit {}
         fun setB(value: Int = 5): Unit {}
@@ -190,4 +191,4 @@ class TestPropertyRequiredness {
 
     private fun BeanDescription.isRequired(propertyName: String): Boolean =
             this.findProperties().find { it.name == propertyName }!!.isRequired
-}
+}

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github114.kt

@@ -57,7 +57,7 @@ class TestGithub114 {
     fun testCallByFunctionalityWithCompanionObjects() {
         val v = Nada.Companion::foo
         assertEquals("OK 42", v.callBy(mapOf()))
-        val v2 = FooWithStaticCreator.Companion::createFromJson.javaMethod!!.kotlinFunction!!
+//        val v2 = FooWithStaticCreator.Companion::createFromJson.javaMethod!!.kotlinFunction!!
 //        println(v2.callBy(mapOf(v2.parameters.first() to FooWithStaticCreator, v2.parameters.drop(1).first() to "asdf")))
     }
 

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github120.kt

@@ -3,8 +3,8 @@ package com.fasterxml.jackson.module.kotlin.test.github
 import com.fasterxml.jackson.annotation.JsonCreator
 import com.fasterxml.jackson.annotation.JsonValue
 import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
-import junit.framework.Assert.assertEquals
 import org.junit.Test
+import kotlin.test.assertEquals
 
 class TestGithub120 {
     data class Foo @JsonCreator(mode = JsonCreator.Mode.DELEGATING) constructor (
@@ -27,4 +27,4 @@ class TestGithub120 {
         val fromString = om.readValue(asString, Bar::class.java)
         assertEquals(bar, fromString)
     }
-}
+}

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github145.kt

@@ -7,6 +7,7 @@ import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
 import com.fasterxml.jackson.module.kotlin.readValue
 import org.junit.Test
 
+@Suppress("UNUSED_VARIABLE")
 class TestGithub145 {
     private val objectMapper = jacksonObjectMapper()
 

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github149.kt

@@ -7,6 +7,7 @@ import com.fasterxml.jackson.annotation.JsonProperty
 import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
 import org.junit.Test
 
+@Suppress("UNUSED_VARIABLE")
 class TestGithub149 {
 
     class Foo(val name: String, attributes: List<FooAtt>) {
@@ -83,4 +84,4 @@ class TestGithub149 {
         val value = mapper.readValue(s, Car::class.java)
 //        print(value)
     }
-}
+}

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github158.kt

@@ -4,6 +4,7 @@ import com.fasterxml.jackson.databind.annotation.JsonDeserialize
 import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
 import com.fasterxml.jackson.module.kotlin.readValue
 import org.junit.Test
+import kotlin.test.assertEquals
 
 class TestGithub158 {
     enum class SampleImpl constructor(override val value: String): Sample {
@@ -21,9 +22,11 @@ class TestGithub158 {
     fun testEnumSerDeser() {
         val mapper = jacksonObjectMapper()
 
-        val json = mapper.writeValueAsString(SampleContainer(SampleImpl.One))
-        println(json)
-        val obj = mapper.readValue<SampleContainer>(json)
+        val original = SampleContainer(SampleImpl.One)
 
+        val json = mapper.writeValueAsString(original)
+//        println(json)
+        val obj = mapper.readValue<SampleContainer>(json)
+        assertEquals(original, obj)
     }
-}
+}

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github161.kt

@@ -17,10 +17,10 @@ class TestGithub161 {
         val json = """{"foo":17}"""
         val objectMapper = jacksonObjectMapper().configure(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES, true)
         try {
-            val foo = objectMapper.readValue(json, Foo::class.java)
+            objectMapper.readValue(json, Foo::class.java)
             fail("Expected an error on the missing primitive value")
         } catch (ex: MismatchedInputException) {
             // success
         }
     }
-}
+}

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github168.kt

@@ -5,22 +5,27 @@ import com.fasterxml.jackson.module.kotlin.MissingKotlinParameterException
 import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
 import com.fasterxml.jackson.module.kotlin.readValue
 import org.junit.Test
+import kotlin.test.assertEquals
 
 class TestGithub168 {
+    @Suppress("UNUSED_PARAMETER")
     class TestClass(@JsonProperty(value = "foo", required = true) foo: String?, val baz: String)
 
     @Test
     fun testIfRequiredIsReallyRequiredWhenNullused() {
         val obj = jacksonObjectMapper().readValue<TestClass>("""{"foo":null,"baz":"whatever"}""")
+        assertEquals("whatever", obj.baz)
     }
 
     @Test(expected = MissingKotlinParameterException::class)
     fun testIfRequiredIsReallyRequiredWhenAbsent() {
         val obj = jacksonObjectMapper().readValue<TestClass>("""{"baz":"whatever"}""")
+        assertEquals("whatever", obj.baz)
     }
 
     @Test
     fun testIfRequiredIsReallyRequiredWhenVauePresent() {
         val obj = jacksonObjectMapper().readValue<TestClass>("""{"foo":"yay!","baz":"whatever"}""")
+        assertEquals("whatever", obj.baz)
     }
-}
+}

src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/failing/Github138.kt

@@ -27,7 +27,7 @@ class TestGithub138 {
         val xml = """<sms Phone="435242423412" Id="43234324">Lorem ipsum</sms>"""
         val xmlMapper = XmlMapper().registerKotlinModule()
         expectFailure<InvalidDefinitionException>("GitHub #138 has been fixed!") {
-            val jsms = xmlMapper.readValue<Sms>(xml)
+            xmlMapper.readValue<Sms>(xml)
         }
     }
 }