Skip to content

Commit 6363de3

Browse files
committed
Fixed cases not implemented in kotlin-module for failing tests
1 parent 73b0950 commit 6363de3

File tree

1 file changed

+43
-8
lines changed
  • src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser.valueClass/serializer/byAnnotation/primitive

1 file changed

+43
-8
lines changed

src/test/kotlin/com/fasterxml/jackson/module/kotlin/kogeraIntegration/ser.valueClass/serializer/byAnnotation/primitive/ByAnnotationTest.kt

Lines changed: 43 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import com.fasterxml.jackson.module.kotlin.testPrettyWriter
77
import com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.serializer.Primitive
88
import kotlin.test.Test
99
import kotlin.test.assertEquals
10+
import kotlin.test.assertNotEquals
1011

1112
class ByAnnotationTest {
1213
companion object {
@@ -16,9 +17,27 @@ class ByAnnotationTest {
1617
.testPrettyWriter()
1718
}
1819

19-
data class NonNullSrc(
20+
data class NonNullFailingSrc(
2021
@JsonSerialize(using = Primitive.Serializer::class)
2122
val paramAnn: Primitive,
23+
)
24+
25+
@Test
26+
fun nonNullFailing() {
27+
val src = NullableFailingSrc(Primitive(0))
28+
29+
assertNotEquals(
30+
"""
31+
{
32+
"paramAnn" : 100
33+
}
34+
""".trimIndent(),
35+
writer.writeValueAsString(src),
36+
"#651 fixed, it needs to be modified to match the original."
37+
)
38+
}
39+
40+
data class NonNullSrc(
2241
@get:JsonSerialize(using = Primitive.Serializer::class)
2342
val getterAnn: Primitive,
2443
@field:JsonSerialize(using = Primitive.Serializer::class)
@@ -27,12 +46,11 @@ class ByAnnotationTest {
2746

2847
@Test
2948
fun nonNull() {
30-
val src = NonNullSrc(Primitive(0), Primitive(1), Primitive(2))
49+
val src = NonNullSrc(Primitive(1), Primitive(2))
3150

3251
assertEquals(
3352
"""
3453
{
35-
"paramAnn" : 100,
3654
"getterAnn" : 101,
3755
"fieldAnn" : 102
3856
}
@@ -41,9 +59,28 @@ class ByAnnotationTest {
4159
)
4260
}
4361

44-
data class NullableSrc(
62+
data class NullableFailingSrc(
4563
@JsonSerialize(using = Primitive.Serializer::class)
4664
val paramAnn: Primitive?,
65+
)
66+
67+
@Test
68+
fun nullableFailing() {
69+
val src = NullableFailingSrc(Primitive(0))
70+
71+
assertNotEquals(
72+
"""
73+
{
74+
"paramAnn" : 100
75+
}
76+
""".trimIndent(),
77+
writer.writeValueAsString(src),
78+
"#651 fixed, it needs to be modified to match the original."
79+
)
80+
}
81+
82+
83+
data class NullableSrc(
4784
@get:JsonSerialize(using = Primitive.Serializer::class)
4885
val getterAnn: Primitive?,
4986
@field:JsonSerialize(using = Primitive.Serializer::class)
@@ -52,12 +89,11 @@ class ByAnnotationTest {
5289

5390
@Test
5491
fun nullableWithoutNull() {
55-
val src = NullableSrc(Primitive(0), Primitive(1), Primitive(2))
92+
val src = NullableSrc(Primitive(1), Primitive(2))
5693

5794
assertEquals(
5895
"""
5996
{
60-
"paramAnn" : 100,
6197
"getterAnn" : 101,
6298
"fieldAnn" : 102
6399
}
@@ -68,12 +104,11 @@ class ByAnnotationTest {
68104

69105
@Test
70106
fun nullableWithNull() {
71-
val src = NullableSrc(null, null, null)
107+
val src = NullableSrc(null, null)
72108

73109
assertEquals(
74110
"""
75111
{
76-
"paramAnn" : null,
77112
"getterAnn" : null,
78113
"fieldAnn" : null
79114
}

0 commit comments

Comments
 (0)