Skip to content

Commit b0e7c31

Browse files
authored
Merge branch '3.x' into tatu/3.0/887-use-module-info
2 parents bf56d81 + 7393d98 commit b0e7c31

File tree

7 files changed

+19
-21
lines changed

7 files changed

+19
-21
lines changed

.github/workflows/dep_build_v3.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ name: Re-build on jackson-databind v3 push
22
on:
33
repository_dispatch:
44
types: [jackson-databind-pushed-v3]
5-
# just for testing
6-
workflow_dispatch:
75

86
permissions:
97
contents: read
@@ -22,7 +20,7 @@ jobs:
2220
steps:
2321
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
2422
with:
25-
ref: master
23+
ref: 3.x
2624
- name: Set up JDK
2725
uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # v4.2.1
2826
with:
@@ -31,5 +29,3 @@ jobs:
3129
cache: 'maven'
3230
- name: Build and test
3331
run: ./mvnw -B -ff -ntp -Dversion.kotlin=${{ matrix.kotlin_version }} clean verify
34-
35-
# No recursive rebuild (yet?)

.github/workflows/main.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ name: Build and Deploy Snapshot
22
on:
33
push:
44
branches:
5-
- master
6-
- "3.0"
5+
- 3.x
76
paths-ignore:
87
- "README.md"
98
- "release-notes/*"
109
pull_request:
1110
branches:
12-
- master
13-
- "3.0"
11+
- 3.x
1412
paths-ignore:
1513
- "README.md"
1614
- "release-notes/*"

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
<dependency>
201201
<groupId>tools.jackson.module</groupId>
202202
<artifactId>jackson-module-kotlin</artifactId>
203-
<version>3.0.0-rc1-SNAPSHOT</version>
203+
<version>3.0.0-rc2</version>
204204
<type>jar</type>
205205
</dependency>
206206
</oldVersion>

release-notes/VERSION

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ Former maintainers:
2222
=== Releases ===
2323
------------------------------------------------------------------------
2424

25+
3.0.0-rc3 (not yet released)
26+
27+
- Branch rename "master" -> "3.x" [JSTEP-12]
28+
2529
3.0.0-rc2 (28-Mar-2025)
2630

2731
#936: `StrictNullChecks` and `SingletonSupport` are now enabled by default

release-notes/VERSION-2.x

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Co-maintainers:
1616
=== Releases ===
1717
------------------------------------------------------------------------
1818

19-
2.19.0 (not yet released)
19+
2.19.0-rc2 (07-Apr-2025)
2020

2121
#929: Added consideration of `JsonProperty.isRequired` added in `2.19` in `hasRequiredMarker` processing.
2222
Previously `JsonProperty.required` was defined as `Boolean` with default `false`,

src/test/kotlin/tools/jackson/module/kotlin/test/DurationTests.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ package tools.jackson.module.kotlin.test
33
import com.fasterxml.jackson.annotation.JsonCreator
44
import com.fasterxml.jackson.annotation.JsonFormat
55
import com.fasterxml.jackson.annotation.JsonFormat.Shape.STRING
6-
import tools.jackson.databind.SerializationFeature
76
import tools.jackson.databind.json.JsonMapper
87
import tools.jackson.module.kotlin.KotlinFeature
98
import tools.jackson.module.kotlin.kotlinModule
109
import tools.jackson.module.kotlin.readValue
1110
import org.junit.jupiter.api.Test
11+
import tools.jackson.databind.cfg.DateTimeFeature
1212
import java.time.Instant
1313
import kotlin.test.assertContentEquals
1414
import kotlin.test.assertEquals
@@ -24,7 +24,7 @@ class DurationTests {
2424
@Test
2525
fun `should serialize Kotlin duration using Java time module`() {
2626
val mapper = mapperBuilder
27-
.disable(SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
27+
.disable(DateTimeFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
2828
.build()
2929

3030
val result = mapper.writeValueAsString(1.hours)
@@ -44,7 +44,7 @@ class DurationTests {
4444
@Test
4545
fun `should serialize Kotlin duration inside list using Java time module`() {
4646
val mapper = mapperBuilder
47-
.disable(SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
47+
.disable(DateTimeFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
4848
.build()
4949

5050
val result = mapper.writeValueAsString(listOf(1.hours, 2.hours, 3.hours))
@@ -64,7 +64,7 @@ class DurationTests {
6464
@Test
6565
fun `should serialize Kotlin duration inside map using Java time module`() {
6666
val mapper = mapperBuilder
67-
.disable(SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
67+
.disable(DateTimeFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
6868
.build()
6969

7070
val result = mapper.writeValueAsString(
@@ -109,8 +109,8 @@ class DurationTests {
109109
@Test
110110
fun `should serialize Kotlin duration inside data class using Java time module`() {
111111
val mapper = mapperBuilder
112-
.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
113-
.disable(SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
112+
.disable(DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS)
113+
.disable(DateTimeFeature.WRITE_DURATIONS_AS_TIMESTAMPS)
114114
.build()
115115

116116
val result = mapper.writeValueAsString(Meeting(Instant.parse("2023-06-20T14:00:00Z"), 1.5.hours))
@@ -143,7 +143,7 @@ class DurationTests {
143143
@Test
144144
fun `should serialize Kotlin duration inside data class using Java time module and mixin`() {
145145
val mapper = mapperBuilder
146-
.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
146+
.disable(DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS)
147147
.addMixIn(Meeting::class.java, MeetingMixin::class.java)
148148
.build()
149149

src/test/kotlin/tools/jackson/module/kotlin/test/ParameterNameTests.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import com.fasterxml.jackson.annotation.JsonCreator
44
import com.fasterxml.jackson.annotation.JsonIgnore
55
import com.fasterxml.jackson.annotation.JsonProperty
66
import tools.jackson.databind.PropertyNamingStrategies
7-
import tools.jackson.databind.SerializationFeature
87
import tools.jackson.module.kotlin.*
98
import tools.jackson.databind.MapperFeature
109
import org.junit.jupiter.api.Test
1110
import tools.jackson.databind.DeserializationFeature
11+
import tools.jackson.databind.cfg.DateTimeFeature
1212
import java.io.StringWriter
1313
import java.util.*
1414
import kotlin.properties.Delegates
@@ -49,11 +49,11 @@ class ParameterNameTests {
4949

5050
private val normalCasedMapper = jacksonMapperBuilder()
5151
.enable(MapperFeature.ALLOW_FINAL_FIELDS_AS_MUTATORS)
52-
.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
52+
.disable(DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS)
5353
.build()
5454

5555
private val pascalCasedMapper = jacksonMapperBuilder()
56-
.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
56+
.disable(DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS)
5757
.propertyNamingStrategy(PropertyNamingStrategies.UPPER_CAMEL_CASE)
5858
.build()
5959

0 commit comments

Comments
 (0)