Fix KotlinAnnotationIntrospector.findSubtypes returning wrong value in super edge case.
#447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's simpler to look at sealedSubclasses directly than to determine isSealed, so I fixed it while I was at it.
k163377
changed the title
KotlinAnnotationIntrospector.findSubtypes returning wrong value in super edge cases.KotlinAnnotationIntrospector.findSubtypes returning wrong value in super edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findSubtypesis defined to returnnullif nothing can be retrieved.https://github.com/FasterXML/jackson-databind/blob/2644cba99ec5e23ffdbe85dfe00fb471e5aa0d9c/src/main/java/com/fasterxml/jackson/databind/AnnotationIntrospector.java#L483
On the other hand, a
sealed classmay not have any classes to inherit from.In this case, the conventional implementation of
findSubtypeswill return an empty List.So I modified it to return
nullin case of an empty list.Also, it is simpler to look at
sealedSubclassesdirectly than to determineisSealed, so I fixed it while I was at it.