[master] fix failing tests after FAIL_ON_NULL_FOR_PRIMITIVES to true [databind#4890]
#880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
reviewed
Jan 9, 2025
| val item = createMapper(false).readValue<TestClassWithNotNullPrimitives>( | ||
| val item = createMapper(false) | ||
| .rebuild() | ||
| .disable(DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES) |
Member
There was a problem hiding this comment.
Would be cleaner to use ObjectReader... but ok for now.
cowtowncoder
approved these changes
Jan 9, 2025
Member
cowtowncoder
left a comment
cowtowncoder
left a comment
There was a problem hiding this comment.
Approving to unblock CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves failing tests affected by FasterXML/jackson-databind#4858