Skip to content

Adjusted tests to change configuration defaults in 3.0 #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Adjusted tests to change configuration defaults in 3.0 #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/test/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModuleTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class KotlinModuleTest {
enable(NullToEmptyMap)
enable(NullIsSameAsDefault)
enable(SingletonSupport)
enable(StrictNullChecks)
enable(NewStrictNullChecks)
enable(KotlinPropertyNameAsImplicitName)
enable(UseJavaDurationConversion)
}.build()
Expand Down Expand Up @@ -100,7 +100,7 @@ class KotlinModuleTest {
@Test
fun builder_EnableStrictNullChecks() {
val module = KotlinModule.Builder().apply {
enable(StrictNullChecks)
enable(NewStrictNullChecks)
}.build()

assertTrue(module.strictNullChecks)
Expand All @@ -114,7 +114,7 @@ class KotlinModuleTest {
enable(NullToEmptyMap)
enable(NullIsSameAsDefault)
enable(SingletonSupport)
enable(StrictNullChecks)
enable(NewStrictNullChecks)
}.build()

val serialized = jdkSerialize(module)
Expand Down
10 changes: 6 additions & 4 deletions src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/StrictNullChecksTestOld.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
package com.fasterxml.jackson.module.kotlin.test

import com.fasterxml.jackson.databind.ObjectMapper
import com.fasterxml.jackson.module.kotlin.KotlinFeature.StrictNullChecks
import com.fasterxml.jackson.module.kotlin.KotlinFeature
import com.fasterxml.jackson.module.kotlin.MissingKotlinParameterException
import com.fasterxml.jackson.module.kotlin.kotlinModule
import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
import com.fasterxml.jackson.module.kotlin.readValue
import org.junit.jupiter.api.Assertions.assertArrayEquals
import org.junit.jupiter.api.Assertions.assertEquals
Expand All @@ -13,7 +12,10 @@ import org.junit.jupiter.api.assertThrows
import kotlin.test.assertNull

class StrictNullChecksTestOld {
private val mapper = ObjectMapper().registerModule(kotlinModule { enable(StrictNullChecks) })
private val mapper = jacksonObjectMapper {
disable(KotlinFeature.NewStrictNullChecks)
enable(KotlinFeature.StrictNullChecks)
}

/** collection tests */

Expand Down
2 changes: 1 addition & 1 deletion src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/GitHub757.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class GitHub757 {
@Test
fun test() {
val kotlinModule = KotlinModule.Builder()
.enable(KotlinFeature.StrictNullChecks)
.enable(KotlinFeature.NewStrictNullChecks)
.build()
val mapper = JsonMapper.builder()
.addModule(kotlinModule)
Expand Down