Skip to content

Commit 06fca1f

Browse files
committed
disable SORT_PROPERTIES_ALPHABETICALLY in tests
1 parent 63f05b5 commit 06fca1f

File tree

4 files changed

+23
-9
lines changed

4 files changed

+23
-9
lines changed

src/test/scala/tools/jackson/module/scala/BaseFixture.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package tools.jackson.module.scala
22

3-
import tools.jackson.databind.ObjectMapper
3+
import tools.jackson.databind.{MapperFeature, ObjectMapper}
44
import tools.jackson.databind.json.JsonMapper
55
import org.scalatest.Outcome
66
import org.scalatest.flatspec.FixtureAnyFlatSpec
@@ -11,7 +11,9 @@ class BaseFixture extends FixtureAnyFlatSpec with Matchers {
1111
type FixtureParam = ObjectMapper
1212

1313
def withFixture(test: OneArgTest): Outcome = {
14-
val builder = JsonMapper.builder().addModule(DefaultScalaModule)
14+
val builder = JsonMapper.builder()
15+
.disable(MapperFeature.SORT_PROPERTIES_ALPHABETICALLY)
16+
.addModule(DefaultScalaModule)
1517
val mapper = builder.build()
1618
test(mapper)
1719
}

src/test/scala/tools/jackson/module/scala/JacksonTest.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
package tools.jackson.module.scala
22

33
import tools.jackson.databind.json.JsonMapper
4-
import tools.jackson.databind.{JacksonModule => DatabindModule}
4+
import tools.jackson.databind.{MapperFeature, JacksonModule => DatabindModule}
55

66
abstract class JacksonTest extends BaseSpec {
77
def module: DatabindModule
88

99
def newBuilder: JsonMapper.Builder = {
10-
JsonMapper.builder().addModule(module)
10+
JsonMapper.builder()
11+
.addModule(module)
12+
.disable(MapperFeature.SORT_PROPERTIES_ALPHABETICALLY)
1113
}
1214

1315
def newMapper: JsonMapper = newBuilder.build()

src/test/scala/tools/jackson/module/scala/deser/CreatorTest.scala

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,9 @@ class CreatorTest extends DeserializationFixture {
155155
.addAllBuiltinModules()
156156
.applyDefaultValuesWhenDeserializing(false)
157157
.build()
158-
val mapper = JsonMapper.builder().addModule(scalaModule).build()
158+
val mapper = initBuilder()
159+
.addModule(scalaModule)
160+
.build()
159161
val deser = mapper.readValue("""{}""", classOf[ConstructorWithDefaultValues])
160162
deser.s shouldEqual null
161163
deser.i shouldEqual 0
@@ -170,7 +172,9 @@ class CreatorTest extends DeserializationFixture {
170172
.addModule(ScalaAnnotationIntrospectorModule)
171173
.applyDefaultValuesWhenDeserializing(false)
172174
.build()
173-
val mapper = JsonMapper.builder().addModule(scalaModule).build()
175+
val mapper = initBuilder()
176+
.addModule(scalaModule)
177+
.build()
174178
val deser = mapper.readValue("""{}""", classOf[ConstructorWithDefaultValues])
175179
deser.s shouldEqual null
176180
deser.i shouldEqual 0
@@ -181,7 +185,9 @@ class CreatorTest extends DeserializationFixture {
181185
}
182186

183187
it should "ignore default values (when MapperFeature is overridden)" in { _ =>
184-
val builder = JsonMapper.builder().disable(MapperFeature.APPLY_DEFAULT_VALUES).addModule(DefaultScalaModule)
188+
val builder = initBuilder()
189+
.disable(MapperFeature.APPLY_DEFAULT_VALUES)
190+
.addModule(DefaultScalaModule)
185191
val mapper = builder.build()
186192
val deser = mapper.readValue("""{}""", classOf[ConstructorWithDefaultValues])
187193
deser.s shouldEqual null
@@ -237,4 +243,9 @@ class CreatorTest extends DeserializationFixture {
237243
val node: JsonNode = f.valueToTree[IntNode](10)
238244
f.convertValue(node, new TypeReference[PositiveLong] {}).value shouldEqual node.asLong()
239245
}
246+
247+
private def initBuilder(): JsonMapper.Builder = {
248+
JsonMapper.builder()
249+
.disable(MapperFeature.SORT_PROPERTIES_ALPHABETICALLY)
250+
}
240251
}

src/test/scala/tools/jackson/module/scala/ser/CaseClassSerializerTest.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package tools.jackson.module.scala.ser
22

33
import com.fasterxml.jackson.annotation.JsonProperty.Access
44
import com.fasterxml.jackson.annotation._
5-
import tools.jackson.databind.json.JsonMapper
65
import tools.jackson.databind.{ObjectMapper, PropertyNamingStrategies}
76
import tools.jackson.module.scala.DefaultScalaModule
87

@@ -139,7 +138,7 @@ class CaseClassSerializerTest extends SerializerTest {
139138
}
140139

141140
def propertyNamingStrategyMapper: ObjectMapper = {
142-
val builder = JsonMapper.builder()
141+
val builder = newBuilder
143142
val settings = builder.baseSettings().`with`(PropertyNamingStrategies.SNAKE_CASE)
144143
builder.baseSettings(settings).addModule(module).build()
145144
}

0 commit comments

Comments
 (0)