Fix InstantSerializer ignoring the JsonFormat shape #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/ser/InstantSerializerBase.java
Show resolved
Hide resolved
datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/ser/InstantSerializer.java
Outdated
Show resolved
Hide resolved
|
Looks good, added some minor comments. One thing we do need -- if not already done -- is to get the CLA: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf it's a one-time thing, good for all contributions, so once we have it, no need to send again. The usual method is to print CLA, fill & sign, scan/photo, email to Thank you again for submitting it! |
|
CLA received, merging. |
cowtowncoder
added a commit
that referenced
this pull request
Apr 30, 2022
|
Merged, thank you @KaseiFR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.