forked from euvl/vue-js-modal
-
Notifications
You must be signed in to change notification settings - Fork 0
Vue 3 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 814b1ac. # Conflicts: # src/components/ModalsContainer.vue
npx browserslist@latest --update-db
needs `cross-env` installation
npm run build
- replace `vue-template-compiler` with `@vue/compiler-sfc` - update `vue-loader` from `15.9.1` to `17.4.2` - install `vue-compat` Commands: - npm install vue-loader@17 vue@3 @vue/compat - npm remove vue-template-compiler - npm install --save-dev @vue/compiler-sfc
Feature flags __VUE_OPTIONS_API__, __VUE_PROD_DEVTOOLS__, __VUE_PROD_HYDRATION_MISMATCH_DETAILS__ are not explicitly defined. You are running the esm-bundler build of Vue, which expects these compile-time feature flags to be globally injected via the bundler config in order to get better tree-shaking in the production bundle.
and disable VueJsModal plugin for now
- upgrade `vue` peer dependency - replace `vue-template-compiler` with `@vue/compiler-sfc` - update `vue-loader` from `15.4.2` to `17.4.2` - install `vue-compat` - remove `vue-hot-reload-api` Commands: - npm install --save-peer vue@3 - npm install vue-loader@17 vue@3 @vue/compat - npm remove vue-template-compiler - npm install --save-dev @vue/compiler-sfc - npm remove vue-hot-reload-api
remove duplicated package `vue-test-utils` Commands: - npm remove vue-test-utils - npm install @vue/test-utils@2 --save-dev
Has to be "terser-webpack-plugin@4" to be compatible with already installed "webpack@4" Commands: - npm remove uglifyjs-webpack-plugin - npm install terser-webpack-plugin@4 --save-dev
- Vue 3 needs vue-jest@5 (vue-jest@next) - vue-jest@5 needs jest@24 - jest@24 needs babel-jest@24 Command: - npm install jest@24 babel-jest@24 vue-jest@next
- remove plain (non-HTML) text interpolation - keep HTML-aware text interpolation via `v-html` attribute
moved here: 1d0995f
- vuepress@1 is built on vue@2 - vuepress@2 needs @vuepress/bundler-webpack, which needs webpack@5 - sass-loader is also different - simplest solution for now: remove vuepress, as it is not essential
- reinstall missing package - was part of vuepress@1 dependency tree (vue@2 etc.)
- in Vue 3 '$listeners' are now part of '$attrs'
- override "sass-loader" and "sass" package versions to the same ones we are using for the plugin - @vuepress/theme-default can also work with those Command: - npm install vuepress@next @vuepress/bundler-webpack@next @vuepress/theme-default@next @vuepress/plugin-search@next --save-dev
unify with plugin and nuxt
- npm uninstall webpack-merge - npm install webpack-merge --save-dev - npm uninstall mini-css-extract-plugin - npm install mini-css-extract-plugin --save-dev - npm uninstall terser-webpack-plugin - npm install terser-webpack-plugin --save-dev - npm uninstall optimize-css-assets-webpack-plugin - npm install css-minimizer-webpack-plugin --save-dev
- replace "optimize-css-assets-webpack-plugin" (webpack 4) with "css-minimizer-webpack-plugin" (webpack 5) - add "terser-webpack-plugin" to requirements -> formerly only indirect dependency of webpack 5 Commands: - npm uninstall optimize-css-assets-webpack-plugin - npm install terser-webpack-plugin --save-dev - npm install css-minimizer-webpack-plugin --save-dev
introduced here: 89b4761
introduced here: 8ecb612
Identifier "h" has already been declared
including tooling
introduced here: 60c7023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates this project from Vue 2 to Vue 3