fix: return false when object contains invalid regex (#25)

* fix: return false when object contains invalid regex

* Update ConditionSpec.groovy

Author: matthew-leng

src/main/java/com/featureprobe/sdk/server/model/Condition.java

@@ -7,6 +7,7 @@
 
 import java.util.*;
 import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
 
 public final class Condition {
 
@@ -126,7 +127,12 @@ private boolean matchStringCondition(FPUser user) {
             return false;
         }
 
-        return stringMatcher.match(subjectValue, this.objects);
+        try {
+            return stringMatcher.match(subjectValue, this.objects);
+        } catch (PatternSyntaxException e) {
+            logger.error("Invalid regex pattern", e);
+            return false;
+        }
     }
 
     private boolean matchSegmentCondition(FPUser user, Map<String, Segment> segments) {

src/test/groovy/com/featureprobe/sdk/server/ConditionSpec.groovy

@@ -98,6 +98,20 @@ class ConditionSpec extends Specification {
         !hitMiss
     }
 
+    def "[matches invalid regex] string condition match"() {
+        when:
+        condition.setObjects(["\\\\\\"])
+        user.with("userId", "13797347245")
+        condition.setPredicate(PredicateType.MATCHES_REGEX)
+        def hitMiss = condition.matchObjects(user, segments)
+        condition.setPredicate(PredicateType.DOES_NOT_MATCH_REGEX)
+        def hitMiss2 = condition.matchObjects(user, segments)
+
+        then:
+        !hitMiss
+        !hitMiss2
+    }
+
     def "[is not any of] string condition match"() {
         when:
         condition.setObjects(["12345", "987654", "665544"])