Trying to fix module_register_fd test on osx...

Author: FedeDP

Lib/module.c

@@ -459,6 +459,7 @@ static int manage_fds(module *mod, m_context *c, int flag, int stop) {
  */
 static int _poll_set_new_evt(module_poll_t *t, m_context *c, int flag) {
     int ret = poll_set_new_evt(t, c, flag);
+    printf("Ret: %d, errno: %d\n", ret, errno);
     /* Workaround for STDIN_FILENO */
     if (ret == -1 && t->fd == STDIN_FILENO && errno == EPERM) {
         ret = 0;

Lib/poll_plugins/kqueue_priv.c

@@ -7,9 +7,7 @@ int poll_create(void) {
     int fd;
 #ifdef __APPLE__
     fd = kqueue();
-// #ifdef FD_CLOEXEC
     fcntl(fd, F_SETFD, FD_CLOEXEC);
-// #endif
 #else
     fd = kqueue1(O_CLOEXEC);
 #endif
@@ -68,9 +66,7 @@ int _pipe(int fd[2]) {
                 flags = 0;
             }
             fcntl(fd[i], F_SETFL, flags | O_NONBLOCK);
-// #ifdef FD_CLOEXEC
             fcntl(fd[i], F_SETFD, FD_CLOEXEC);
-// #endif
         }
     }
     return ret;

TODO.md

@@ -10,7 +10,8 @@
 
 - [x] Fix CMakeLists to runt tests even if valgrind could not be found
 
-- [ ] Fix tests on osx? module_(de)register_fd fails
+- [ ] Fix tests on osx? module_register_fd fails
+- [x] Special handling of STDIN_FILENO in poll_set_new_evt: it returns EPERM but it is actually pollable.
 
 ## 3.1.0