Corrected NTP_KEY list name in SONiC Yang (sonic-net#23401)

sonic-buildimage : sonic-net#23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182

Why I did it
To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790
Some sonic yang changes are required, which is done under this PR

sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179

Work item tracking
NA

How I did it
In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST
to
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST
How to verify it
Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine

Signed-off-by: Feng Pan <[email protected]>

Author: Verma-Anukul

src/sonic-yang-models/tests/yang_model_tests/tests_config/ntp.json

@@ -28,7 +28,7 @@
                 ]
             },
             "sonic-ntp:NTP_KEY": {
-                "NTP_KEYS_LIST": [
+                "NTP_KEY_LIST": [
                     {
                         "id": 10,
                         "value": "bHVtb3M="
@@ -422,7 +422,7 @@
     "NTP_KEY_VALID": {
         "sonic-ntp:sonic-ntp": {
             "sonic-ntp:NTP_KEY": {
-                "NTP_KEYS_LIST": [
+                "NTP_KEY_LIST": [
                     {
                         "id": 20,
                         "type": "md5",
@@ -448,7 +448,7 @@
     "NTP_KEY_ID_INVALID": {
         "sonic-ntp:sonic-ntp": {
             "sonic-ntp:NTP_KEY": {
-                "NTP_KEYS_LIST": [
+                "NTP_KEY_LIST": [
                     {
                         "id": 100000
                     }
@@ -459,7 +459,7 @@
     "NTP_KEY_TRUSTED_INVALID": {
         "sonic-ntp:sonic-ntp": {
             "sonic-ntp:NTP_KEY": {
-                "NTP_KEYS_LIST": [
+                "NTP_KEY_LIST": [
                     {
                         "id": 20,
                         "trusted": "nope"
@@ -471,7 +471,7 @@
     "NTP_KEY_TYPE_INVALID": {
         "sonic-ntp:sonic-ntp": {
             "sonic-ntp:NTP_KEY": {
-                "NTP_KEYS_LIST": [
+                "NTP_KEY_LIST": [
                     {
                         "id": 20,
                         "type": "md6"
@@ -483,7 +483,7 @@
     "NTP_KEY_VALUE_INVALID": {
         "sonic-ntp:sonic-ntp": {
             "sonic-ntp:NTP_KEY": {
-                "NTP_KEYS_LIST": [
+                "NTP_KEY_LIST": [
                     {
                         "id": 20,
                         "value": ""

src/sonic-yang-models/yang-models/sonic-ntp.yang

@@ -50,6 +50,11 @@ module sonic-ntp {
             "Add extended configuration options";
     }
 
+    revision 2025-07-21 {
+        description
+            "Corrected NTP_KEY_LIST list name";
+    }
+
     typedef association-type {
         description "NTP server association type";
         type enumeration {
@@ -192,7 +197,7 @@ module sonic-ntp {
                 leaf key {
                     description "NTP server key ID";
                     type leafref {
-                        path /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST/ntp:id;
+                        path /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST/ntp:id;
                     }
                 }
 
@@ -234,7 +239,7 @@ module sonic-ntp {
 
             description "NTP authentication keys inventory";
 
-            list NTP_KEYS_LIST {
+            list NTP_KEY_LIST {
                 description "NTP authentication keys inventory";
                 key "id";
 
@@ -261,7 +266,7 @@ module sonic-ntp {
                     default md5;
                     description "NTP authentication key type";
                 }
-            } /* end of list NTP_KEYS_LIST */
+            } /* end of list NTP_KEY_LIST */
 
         } /* end of container NTP_KEY */