Apparent discrepancy between Far field data plotting 2D vs 3D

[eisendaniel]

emerge version: 1.0.1
INFO: modelling simple linear patch antenna with probe feed

I may misinterpreting the syntax but when plotting different polarizations in 2D ,plot_ff_polar(...), I get the expected distinct plots.

ff = data.field.find(freq=fc)\
    .farfield_2d((0, 0, 1), (1, 0, 0), boundary_selection)

legand = ["normE", "Ex", "Ey", "Ez", "Erhcp", "Elhcp"]

plot_ff_polar(ff.ang, [ff.normE/em.lib.EISO, ff.Ex/em.lib.EISO, ff.Ey/em.lib.EISO, ff.Ez/em.lib.EISO, ff.Erhcp/em.lib.EISO, ff.Elhcp/em.lib.EISO],
              dB=True, dBfloor=-25, labels=legand)

However, when using the surfplot function to produce the same plots in 3D, the surfaces displayed in the pyvista are identical.

# Compute full 3D far-field and display surface colored by |E|
ff3d = data.field.find(freq=fc).farfield_3d(boundary_selection)

normE = ff3d.surfplot('normE',
                     offset=(0,0,0))
model.display.add_surf(*normE,cmap="jet")

Ey = ff3d.surfplot('Ey',
                     offset=(3,0,0))
model.display.add_surf(*Ey,cmap="jet")

Ex = ff3d.surfplot('Ex',
                     offset=(6,0,0))
model.display.add_surf(*Ex,cmap="jet")

Erhcp = ff3d.surfplot('Erhcp',
                     offset=(9,0,0))
model.display.add_surf(*Erhcp,cmap="jet")

Elhcp = ff3d.surfplot('Elhcp',
                     offset=(12,0,0))
model.display.add_surf(*Elhcp,cmap="jet")

model.display.show()

[eisendaniel]

Seems that in FarFieldData.surfplot(...) the line F = mapping(self.__dict__.get(polarization, self.normE)) always defaults to self.normE
as the polarization options are not members but @property / functions

[FennisRobert]

Oh yeah you are right... Stupid. I'll fix it immediately and put it in todays patch :) Thanks. Never realized!

[FennisRobert]

I should have used getattr just like all the other functions. Apparently forgot to update this one. I'l update it tonight. In the mean time you can patch it manually using: F = mapping(getattr(self, polarization))!

[eisendaniel]

Cheers. Great release btw. Would you prefer this sort of thing to be submitted as an issue?

[FennisRobert]

For now its not that important because there aren't that many users but eventually yes so that people can see it if the issue already exists and is being worked on :)