Add ADB concurrent process limit

Author: Fernthedev

lib/main.dart

@@ -2,6 +2,7 @@ import 'package:desktop_adb_file_browser/pages/main/browser.dart';
 import 'package:desktop_adb_file_browser/pages/main/devices.dart';
 import 'package:desktop_adb_file_browser/pages/main/logger.dart';
 import 'package:desktop_adb_file_browser/pages/main_page.dart';
+import 'package:desktop_adb_file_browser/riverpod/settings.dart';
 import 'package:desktop_adb_file_browser/src/pigeon_impl.dart';
 import 'package:flex_color_scheme/flex_color_scheme.dart';
 import 'package:flutter/foundation.dart';
@@ -10,6 +11,7 @@ import 'package:flutter/services.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:path_provider/path_provider.dart';
 import 'package:routemaster/routemaster.dart';
+import 'package:shared_preferences/shared_preferences.dart';
 import 'package:trace/trace.dart';
 
 import 'package:path/path.dart' as path;
@@ -54,6 +56,8 @@ void main() async {
 
   WidgetsFlutterBinding.ensureInitialized();
 
+  final prefs = SharedPreferences.getInstance();
+
   final ConsoleLogger logger = ConsoleLogger(
     filter: DefaultLogFilter(
       LogLevel.verbose,
@@ -82,7 +86,10 @@ void main() async {
 
   Trace.verbose("Pigeon");
   native2flutter = Native2FlutterImpl();
-  runApp(const ProviderScope(child: MyApp()));
+  runApp(ProviderScope(
+    overrides: [preferencesProvider.overrideWithValue(await prefs)],
+    child: const MyApp(),
+  ));
 }
 
 class MyApp extends StatelessWidget {

lib/riverpod/settings.dart

@@ -0,0 +1,57 @@
+import 'dart:convert';
+
+import 'package:desktop_adb_file_browser/utils/adb.dart';
+import 'package:freezed_annotation/freezed_annotation.dart';
+import 'package:riverpod_annotation/riverpod_annotation.dart';
+import 'package:shared_preferences/shared_preferences.dart';
+import 'package:trace/trace.dart';
+
+part 'settings.g.dart';
+part 'settings.freezed.dart';
+
+@freezed
+class SettingsData with _$SettingsData {
+  const factory SettingsData({@Default(10) int multipleAdbInstances}) =
+      _SettingsData;
+
+  factory SettingsData.fromJson(Map<String, Object?> json) =>
+      _$SettingsDataFromJson(json);
+}
+
+@Riverpod(keepAlive: true)
+SharedPreferences preferences(PreferencesRef ref) {
+  throw UnimplementedError();
+}
+
+@Riverpod(keepAlive: true)
+class Settings extends _$Settings {
+  @override
+  SettingsData build() {
+    // hook into ADB
+    ref.listenSelf((old, newV) {
+      Trace.info("Listen self");
+
+      Adb.settings = newV;
+      if (old != newV) {
+        save();
+      }
+    });
+
+    final json = ref.watch(preferencesProvider).getString("settings");
+    if (json == null) return const SettingsData();
+
+    return SettingsData.fromJson(jsonDecode(json));
+  }
+
+  Future<void> save() async {
+    var prefs = ref.read(preferencesProvider);
+
+    await prefs.setString("settings", jsonEncode(state.toJson()));
+
+    Trace.info("Saving prefs");
+  }
+
+  void update(SettingsData settings) {
+    state = settings;
+  }
+}

lib/riverpod/settings.freezed.dart

@@ -1,9 +1,11 @@
+import 'dart:collection';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:archive/archive_io.dart';
 import 'package:async/async.dart';
 import 'package:desktop_adb_file_browser/riverpod/package_list.dart';
+import 'package:desktop_adb_file_browser/riverpod/settings.dart';
 import 'package:desktop_adb_file_browser/utils/platform.dart';
 import 'package:dio/dio.dart';
 import 'package:flutter/cupertino.dart';
@@ -32,6 +34,9 @@ abstract class Adb {
 
   static Context get hostPath => host_path.context;
 
+  static SettingsData settings = const SettingsData();
+  static final Set<Future<ProcessResult>> _runningProcesses = {};
+
   static Future<void> downloadADB(
       DownloadProgressCallback c, CancelToken cancelToken) async {
     String adbFinalURL = adbDownloadURL;
@@ -117,16 +122,25 @@ abstract class Adb {
 
     var adbPath = await _locateAdbPath();
 
-    // ignore: avoid_print
     Trace.info("Running adb command: \"$adbPath $newArgs\"");
 
-    var process = await Process.run(adbPath, newArgs, runInShell: true);
+    while (_runningProcesses.length >= settings.multipleAdbInstances.abs()) {
+      await Future.delayed(const Duration(milliseconds: 10));
+    }
+
+    var processFuture = Process.run(adbPath, newArgs, runInShell: true);
+
+    // add to queue
+    _runningProcesses.add(processFuture);
+
+    var process = await processFuture;
     if (process.stderr != null && process.stderr.toString().isNotEmpty) {
       final error = process.stderr;
       Trace.verbose("Error $error");
       debugPrintStack();
       throw error.toString();
     }
+    _runningProcesses.remove(processFuture);
 
     // if (process.exitCode != 0) throw "Process exit code was not 0!";