Skip to content

No wrapping Vararg in UnionAll#1285

Merged
fredrikekre merged 1 commit intomasterfrom
kam/fixvararg
Feb 17, 2026
Merged

No wrapping Vararg in UnionAll#1285
fredrikekre merged 1 commit intomasterfrom
kam/fixvararg

Conversation

@KnutAM
Copy link
Member

@KnutAM KnutAM commented Feb 16, 2026

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.25%. Comparing base (f245839) to head (9c9c717).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1285   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          40       40           
  Lines        6750     6750           
=======================================
  Hits         6362     6362           
  Misses        388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KnutAM
Copy link
Member Author

KnutAM commented Feb 16, 2026

Fixes the following warning during precompilation

Precompiling packages finished.
  5 dependencies successfully precompiled in 11 seconds. 166 already precompiled.
  1 dependency had output during precompilation:
┌ Ferrite
│  WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
│  You may need to write `f(x::Vararg{T})` rather than `f(x::Vararg{<:T})` or `f(x::Vararg{T}) where T` instead of `f(x::Vararg{T} where T)`.
│  To make this warning an error, and hence obtain a stack trace, use `julia --depwarn=error`.
└  

@KristofferC
Copy link
Collaborator

I'm not sure this really need to be tested

@fredrikekre fredrikekre merged commit 236eb50 into master Feb 17, 2026
15 of 16 checks passed
@fredrikekre fredrikekre deleted the kam/fixvararg branch February 17, 2026 14:45
@KnutAM
Copy link
Member Author

KnutAM commented Feb 17, 2026

I'm not sure this really need to be tested

I was thinking in general if there was an easy test using deprecated syntax etc. occurring during precompilation could be caught. But agreed that it is not crucial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments