Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1285 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 40 40
Lines 6750 6750
=======================================
Hits 6362 6362
Misses 388 388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Fixes the following warning during precompilation Precompiling packages finished.
5 dependencies successfully precompiled in 11 seconds. 166 already precompiled.
1 dependency had output during precompilation:
┌ Ferrite
│ WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
│ You may need to write `f(x::Vararg{T})` rather than `f(x::Vararg{<:T})` or `f(x::Vararg{T}) where T` instead of `f(x::Vararg{T} where T)`.
│ To make this warning an error, and hence obtain a stack trace, use `julia --depwarn=error`.
└ |
Collaborator
|
I'm not sure this really need to be tested |
KristofferC
approved these changes
Feb 17, 2026
Member
Author
I was thinking in general if there was an easy test using deprecated syntax etc. occurring during precompilation could be caught. But agreed that it is not crucial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was missed in #872, not sure how this could be tested to catch...?
https://github.com/JuliaLang/julia/blob/3a3289a17f5a36feddf0898b67788b894a5c7440/src/jltypes.c#L919-L920