Fix sketch tests - wait for dynamic canvas creation

- Added waitForDesignerReady() helper function
- Canvas is created dynamically by designer.js, not in Razor markup
- Tests now wait for #designer-stage div and canvas initialization
- Use correct selector: '#designer-stage canvas' not 'canvas'
- Added 3-second wait for JavaScript module to load
- Updated canvas drawing tests (line, rect, circle)
- Updated toolbar and canvas visibility tests

This addresses the 44 failing sketch tests that were timing out
because they expected immediate canvas availability.

Author: FiftyEightSoftware

TEST_FAILURE_ANALYSIS.md

@@ -0,0 +1,265 @@
+# Test Failure Analysis - October 30, 2025
+
+## Summary
+
+**Total Tests Run:** 342 tests  
+**Status:** 190 passed, 152 failed/skipped
+
+### Pass Rate: **55.6%** (was 92.8% before)
+
+---
+
+## Critical Issues by Category
+
+### 1. **Sketch/Designer Tests** - MAJOR REGRESSION ❌
+**Status:** 44/49 tests FAILING (89.8% failure rate)
+
+All newly implemented sketch tests are timing out at 60 seconds, suggesting the Designer page is not functioning:
+
+**Affected Tests:**
+- `navigate to sketches from job` - Timeout
+- `create new sketch from job` - Timeout  
+- `designer toolbar loads correctly` - Timeout
+- `change sketch units` - Timeout
+- `set sketch name` - Timeout
+- `canvas loads and is interactive` - Timeout
+- All canvas drawing tests (line, rect, circle) - Timeout
+- All keyboard shortcut tests - Timeout
+- All export tests (PNG, JSON, SVG, DXF) - Timeout
+- All advanced feature tests - Timeout
+
+**Only Passing:**
+- ✅ `discard draft` (2.3s)
+- A few basic tests that don't interact with designer
+
+**Root Cause Hypothesis:**
+1. Designer page (`/designer/{jobId}`) may not load properly
+2. Canvas element not rendering
+3. Toolbar buttons not appearing with expected names
+4. JavaScript initialization failing
+5. WebAssembly not loading correctly for designer
+
+**Action Required:** Verify Designer.razor exists and inspect actual page structure
+
+---
+
+### 2. **Accounting Tests** - ALL SKIPPED ⚠️
+**Status:** 24/24 tests SKIPPED
+
+All accounting-ui.spec.ts tests are skipped (marked with `-`):
+- accounting tab visibility
+- dashboard navigation
+- statistics cards
+- companies page
+- invoices page
+- reports page
+- chart of accounts
+
+**Root Cause:** Tests may be conditionally skipped or accounting feature not enabled
+
+---
+
+### 3. **Ledger Integration Tests** - TIMEOUTS ❌
+**Status:** 9/15 tests FAILING (60% failure rate)
+
+Multiple ledger tests timing out at 22-23 seconds:
+
+**Failing:**
+- ✘ journal entries page loads with company selector (22.8s timeout)
+- ✘ trial balance page shows company selector (22.5s timeout)
+- ✘ profit and loss page has company selector (22.5s timeout)
+- ✘ VAT summary page shows MTD boxes (22.5s timeout)
+- ✘ ledger invoices page has create modal (22.5s timeout)
+- ✘ all ledger pages handle empty company list (22.5s timeout)
+
+**Passing:**
+- ✅ trial balance shows balanced/unbalanced status (2.3s)
+- ✅ profit and loss shows revenue and expenses (2.3s)
+- ✅ VAT summary shows MTD information box (2.3s)
+- ✅ invoice create modal has line item functionality (2.2s)
+- ✅ invoice modal can be closed (2.2s)
+- ✅ export CSV buttons present (4.4s)
+
+**Pattern:** Tests that check for specific UI elements timeout, but tests that verify data/content pass quickly
+
+**Root Cause Hypothesis:** Company selector dropdown not appearing or taking too long to load
+
+---
+
+### 4. **Accounting Blazor Tests** - TIMEOUTS ❌
+**Status:** 3/3 tests FAILING (100% failure rate)
+
+- ✘ accounting dashboard loads and shows stats (60s timeout)
+- ✘ can navigate to companies page (60s timeout)
+- ✘ companies page shows create modal (60s+ timeout)
+
+**Root Cause:** Similar to ledger tests - accounting pages not loading within timeout
+
+---
+
+### 5. **Onboarding Tests** - SKIPPED ⚠️
+**Status:** 6 tests SKIPPED
+
+Tests marked with `-`:
+- complete onboarding flow - save credentials
+- validation - prevents invalid VAT format
+- credentials persist across sessions
+- success message appears on save
+
+**Root Cause:** Likely flaky or environment-dependent tests that are conditionally skipped
+
+---
+
+### 6. **API Tests** - 2 SKIPPED
+**Status:** Most passing, 2 skipped
+
+- `-` dev reseed endpoint (chromium)
+- `-` dev reseed endpoint (webkit)
+
+**Root Cause:** Dev reseed likely disabled in test environment
+
+---
+
+## Passing Test Categories ✅
+
+### Strong Performance:
+- ✅ **API Tests:** 95%+ pass rate
+- ✅ **CORS Tests:** 100% pass rate
+- ✅ **UI Smoke Tests:** 100% pass rate
+- ✅ **Onboarding UI Tests:** 90%+ pass rate
+- ✅ **Dashboard Tests:** 100% pass rate
+- ✅ **Invoice Tests:** 100% pass rate
+- ✅ **Workflow Tests:** 100% pass rate
+
+---
+
+## Immediate Action Items
+
+### Priority 1: Sketch/Designer Tests (CRITICAL)
+
+1. **Verify Designer page exists:**
+   ```bash
+   # Check if file exists
+   ls -la ai_mate_blazor/Pages/Designer.razor
+   ```
+
+2. **Inspect actual page structure:**
+   - Visit `/designer/{valid-job-id}` in browser
+   - Check browser console for errors
+   - Verify canvas element exists
+   - Check button names match test expectations
+
+3. **Common Issues to Check:**
+   - Is WebAssembly loading?
+   - Are JavaScript files loaded?
+   - Canvas rendering properly?
+   - Button labels exact matches ("Line" vs "line")?
+   - Tool buttons using `<button>` vs `<a>` tags?
+
+4. **Quick Fix Test:**
+   Run single test in headed mode to see what's happening:
+   ```bash
+   npm run test:e2e:headed -- tests/ui.sketches.spec.ts -g "designer toolbar"
+   ```
+
+### Priority 2: Ledger Tests
+
+1. **Check company selector:**
+   - Visit ledger pages in browser
+   - Verify company dropdown appears
+   - Check load time
+
+2. **Increase timeout if needed:**
+   ```typescript
+   await page.waitForLoadState('networkidle', { timeout: 30000 });
+   ```
+
+### Priority 3: Accounting Tests
+
+1. **Determine why tests are skipped:**
+   - Check test file for `.skip()` or conditional logic
+   - Verify accounting feature is enabled
+
+2. **Enable and run:**
+   ```bash
+   npm run test:e2e -- tests/accounting-ui.spec.ts
+   ```
+
+---
+
+## Test Stability Recommendations
+
+### 1. Add Debug Logging
+```typescript
+test('failing test', async ({ page }) => {
+  console.log('Navigating to designer...');
+  await page.goto('/designer/123');
+  
+  console.log('Waiting for page load...');
+  await page.waitForLoadState('networkidle');
+  
+  console.log('Looking for canvas...');
+  const canvas = page.locator('canvas').first();
+  console.log('Canvas found:', await canvas.isVisible());
+});
+```
+
+### 2. Take Screenshots on Failure
+Add to `playwright.config.ts`:
+```typescript
+use: {
+  screenshot: 'only-on-failure',
+  video: 'retain-on-failure',
+}
+```
+
+### 3. Increase Timeouts for Slow Tests
+```typescript
+test.setTimeout(90000); // 90 seconds for slow tests
+```
+
+### 4. Add Retry Logic for Flaky Selectors
+```typescript
+await expect(page.locator('button', { name: 'Save' }))
+  .toBeVisible({ timeout: 30000 });
+```
+
+---
+
+## Next Steps
+
+1. **Start backend and frontend:**
+   ```bash
+   ./scripts/start.sh
+   ```
+
+2. **Manually test designer page:**
+   - Create a job
+   - Navigate to sketches
+   - Try to create new sketch
+   - Verify page loads and tools work
+
+3. **Run single failing test in headed mode:**
+   ```bash
+   npm run test:e2e:headed -- tests/ui.sketches.spec.ts -g "navigate to sketches"
+   ```
+
+4. **Check browser console for errors**
+
+5. **Fix designer page issues first** (biggest impact - 44 tests)
+
+6. **Then tackle ledger timeouts** (9 tests)
+
+7. **Finally investigate skipped tests** (30+ tests)
+
+---
+
+## Expected Improvement
+
+If we fix the Designer page:
+- **Current:** 190/342 passed (55.6%)
+- **After Designer fix:** 234/342 passed (68.4%)
+- **After Ledger fix:** 243/342 passed (71.1%)
+- **After enabling skipped:** ~273/342 passed (79.8%)
+
+**Target:** 90%+ pass rate (308+ tests passing)

ai_mate_blazor/bin/Debug/net9.0/ai_mate_blazor.dll

@@ -1,7 +1,7 @@
 {
   "mainAssemblyName": "ai_mate_blazor",
   "resources": {
-    "hash": "sha256-NAMeWOKjbnDRjxzVe0NO8ppEzvl+qlIkqFlHCMyB32c=",
+    "hash": "sha256-95dWszHMwY0H55OJ6ElwfAo1s8tbFp3QEcITyi57RGo=",
     "fingerprinting": {
       "Microsoft.AspNetCore.Authorization.tnyc7xpluy.wasm": "Microsoft.AspNetCore.Authorization.wasm",
       "Microsoft.AspNetCore.Components.t32damlu4o.wasm": "Microsoft.AspNetCore.Components.wasm",
@@ -201,8 +201,8 @@
       "icudt_CJK.tjcz0u77k5.dat": "icudt_CJK.dat",
       "icudt_EFIGS.tptq2av103.dat": "icudt_EFIGS.dat",
       "icudt_no_CJK.lfu7j35m59.dat": "icudt_no_CJK.dat",
-      "ai_mate_blazor.pkr4c7ahfg.wasm": "ai_mate_blazor.wasm",
-      "ai_mate_blazor.z5mhoqt34z.pdb": "ai_mate_blazor.pdb"
+      "ai_mate_blazor.ojnxkfvvf5.wasm": "ai_mate_blazor.wasm",
+      "ai_mate_blazor.dwsl6trg2v.pdb": "ai_mate_blazor.pdb"
     },
     "jsModuleNative": {
       "dotnet.native.50iqa8w3ys.js": "sha256-pQdXuxfVeqYHOwd5HUM2ERd7OnXirj9JTF37b6OdTAc="
@@ -412,10 +412,10 @@
       "WindowsBase.361km0836k.wasm": "sha256-FacUCEIJYTnbOWgX/R9QP2QnurqRZwRIkDAH0N9z69s=",
       "mscorlib.qiu3j3msqk.wasm": "sha256-QvztpxTOEw4aMIl7zP3QtsPLNv/IWaK5wq22J4ReGrA=",
       "netstandard.lp03u0xxi4.wasm": "sha256-WVQsxULiAiEbyXLKolS7txnWVT82SsvsuMe4jJ+SqqI=",
-      "ai_mate_blazor.pkr4c7ahfg.wasm": "sha256-Z7Omq0WXR9rJluHYZJZInFE6qT1A2+XZgLNj5Of1vzM="
+      "ai_mate_blazor.ojnxkfvvf5.wasm": "sha256-dNXnPkKtgd8+DVJtGYquFwpMkhOkymFDav/LqU7AVUc="
     },
     "pdb": {
-      "ai_mate_blazor.z5mhoqt34z.pdb": "sha256-d9on+aMeY1UI1YPNMPsBxsK8w72T68qKQElT7lRhpQc="
+      "ai_mate_blazor.dwsl6trg2v.pdb": "sha256-jY8W+QhBxnluh/gByNbk3Wp2Soe05gtMILeXbJyUt5U="
     }
   },
   "cacheBootResources": true,

ai_mate_blazor/bin/Debug/net9.0/ai_mate_blazor.pdb

@@ -1,5 +1,5 @@
 self.assetsManifest = {
-  "version": "2Fpl+6jV",
+  "version": "v/2cbzmu",
   "assets": [
     {
       "hash": "sha256-HPC6AdTYY+y+nGoZaYsDtUdttnjFfcfmkkn/91QRzF8=",
@@ -766,15 +766,15 @@ self.assetsManifest = {
       "url": "_framework/WindowsBase.361km0836k.wasm"
     },
     {
-      "hash": "sha256-Z7Omq0WXR9rJluHYZJZInFE6qT1A2+XZgLNj5Of1vzM=",
-      "url": "_framework/ai_mate_blazor.pkr4c7ahfg.wasm"
+      "hash": "sha256-jY8W+QhBxnluh/gByNbk3Wp2Soe05gtMILeXbJyUt5U=",
+      "url": "_framework/ai_mate_blazor.dwsl6trg2v.pdb"
     },
     {
-      "hash": "sha256-d9on+aMeY1UI1YPNMPsBxsK8w72T68qKQElT7lRhpQc=",
-      "url": "_framework/ai_mate_blazor.z5mhoqt34z.pdb"
+      "hash": "sha256-dNXnPkKtgd8+DVJtGYquFwpMkhOkymFDav/LqU7AVUc=",
+      "url": "_framework/ai_mate_blazor.ojnxkfvvf5.wasm"
     },
     {
-      "hash": "sha256-qmpHp4fHw0wHuXNW3NnWJirU8XkR4FklOkipnkjwqJw=",
+      "hash": "sha256-ShZyo3WLi9HvqmaBmwJayBQzBz4znOtuacddnOG0UUw=",
       "url": "_framework/blazor.boot.json"
     },
     {
@@ -834,7 +834,7 @@ self.assetsManifest = {
       "url": "appsettings.json"
     },
     {
-      "hash": "sha256-/7y+ahLqo3DUPX99bHc0eqlXYVdXN5eAiAdOlDPVjBM=",
+      "hash": "sha256-uyurN+CEp5SP05csE+9X7Aev2zaEv7XQ7eCQNNyniCg=",
       "url": "css/app.css"
     },
     {
@@ -1049,6 +1049,10 @@ self.assetsManifest = {
       "hash": "sha256-+rSbNw5rFeqxB4zdmkY3wTDGRxdGAqauZpAzSIFyoXk=",
       "url": "lib/bootstrap/dist/js/bootstrap.min.js.map"
     },
+    {
+      "hash": "sha256-ko+OTN5utoyP+rLW35qp2IOt0qXrLMYr8U3mePttdZE=",
+      "url": "manifest.json"
+    },
     {
       "hash": "sha256-+3v+gcIsSzK1xCyi/FW1mEQEf6AuqgWQHhnB5fF3dwE=",
       "url": "manifest.webmanifest"

ai_mate_blazor/bin/Debug/net9.0/ai_mate_blazor.staticwebassets.endpoints.json

@@ -1,4 +1,4 @@
-/* Manifest version: 2Fpl+6jV */
+/* Manifest version: v/2cbzmu */
 // In development, always fetch from the network and do not enable offline support.
 // This is because caching would make development more difficult (changes would not
 // be reflected on the first load after each change).