chore: address review

Author: silent-cipher

src/app/service-providers/data/column-definition.tsx

@@ -1,9 +1,9 @@
 import { ID } from '@filecoin-foundation/ui-filecoin/Table/ID'
 import { YesNoStatus } from '@filecoin-foundation/ui-filecoin/Table/YesNoStatus'
-import { ExternalTextLink } from '@filecoin-foundation/ui-filecoin/TextLink/ExternalTextLink'
 import { createColumnHelper } from '@tanstack/react-table'
 
 import { CompactPeerID } from '@/components/CompactPeerID'
+import { PdpScanLink } from '@/components/PdpScanLink'
 import { ProviderOverview } from '@/components/ProviderOverview'
 import { SoftwareVersion } from '@/components/SoftwareVersion'
 
@@ -55,9 +55,10 @@ export const columns = [
   columnHelper.accessor('checkActivityUrl', {
     header: 'Check Activity',
     cell: (info) => (
-      <ExternalTextLink href={info.getValue()}>
-        View on PDP Scan
-      </ExternalTextLink>
+      <PdpScanLink
+        pdpScanUrl={info.getValue()}
+        providerName={info.row.original.name}
+      />
     ),
     enableSorting: false,
   }),

src/app/warm-storage-service/data/column-definition.tsx

@@ -1,8 +1,8 @@
 import { ID } from '@filecoin-foundation/ui-filecoin/Table/ID'
-import { ExternalTextLink } from '@filecoin-foundation/ui-filecoin/TextLink/ExternalTextLink'
 import { createColumnHelper } from '@tanstack/react-table'
 
 import { CompactPeerID } from '@/components/CompactPeerID'
+import { PdpScanLink } from '@/components/PdpScanLink'
 import { ProviderOverview } from '@/components/ProviderOverview'
 import { SoftwareVersion } from '@/components/SoftwareVersion'
 
@@ -48,9 +48,10 @@ export const columns = [
   columnHelper.accessor('checkActivityUrl', {
     header: 'Check Activity',
     cell: (info) => (
-      <ExternalTextLink href={info.getValue()}>
-        View on PDP Scan
-      </ExternalTextLink>
+      <PdpScanLink
+        pdpScanUrl={info.getValue()}
+        providerName={info.row.original.name}
+      />
     ),
     enableSorting: false,
   }),

src/components/PdpScanLink.tsx

@@ -0,0 +1,17 @@
+import { ExternalTextLink } from '@filecoin-foundation/ui-filecoin/TextLink/ExternalTextLink'
+
+type PdpScanLinkProps = {
+  pdpScanUrl: string
+  providerName: string
+}
+
+export function PdpScanLink({ pdpScanUrl, providerName }: PdpScanLinkProps) {
+  return (
+    <ExternalTextLink
+      href={pdpScanUrl}
+      aria-label={`View activity for provider ${providerName} on PDP Scan`}
+    >
+      View on PDP Scan
+    </ExternalTextLink>
+  )
+}

src/services/providers/index.ts

@@ -85,9 +85,7 @@ async function enrichProviders(
   providers: BaseProviderData[],
   network: Network,
 ): Promise<ServiceProvider[]> {
-  const providersWithVersions: Array<
-    BaseProviderData & { softwareVersion?: string; checkActivityUrl?: string }
-  > = []
+  const providersWithVersions: ServiceProvider[] = []
 
   // Process providers in batches
   for (let i = 0; i < providers.length; i += VERSION_FETCH_CONCURRENCY) {