feat: relaxed constraints on setViewContract (#310)

issue #303 demands
relaxation before mainnet.

To be rescinded later prior to mainnet deployment

Author: redpanda-f

service_contracts/abi/FilecoinWarmStorageService.abi.json

@@ -1449,17 +1449,6 @@
     ],
     "anonymous": false
   },
-  {
-    "type": "error",
-    "name": "AddressAlreadySet",
-    "inputs": [
-      {
-        "name": "field",
-        "type": "uint8",
-        "internalType": "enum Errors.AddressField"
-      }
-    ]
-  },
   {
     "type": "error",
     "name": "AddressEmptyCode",

service_contracts/src/FilecoinWarmStorageService.sol

@@ -431,8 +431,16 @@ contract FilecoinWarmStorageService is
      * @param _viewContract Address of the view contract
      */
     function setViewContract(address _viewContract) external onlyOwner {
+        // Ensure the view contract address is not the zero address
         require(_viewContract != address(0), Errors.ZeroAddress(Errors.AddressField.View));
-        require(viewContractAddress == address(0), Errors.AddressAlreadySet(Errors.AddressField.View));
+
+        // Require that the existing set address is still zero (one-time setup only)
+        // NOTE: This check is commented out to allow setting the view contract easily during migrations prior to GA
+        //       GH ISSUE: https://github.com/FilOzone/filecoin-services/issues/303
+        //       This check needs to be re-enabled before mainnet deployment to prevent changing the view contract later.
+
+        // require(viewContractAddress == address(0), Errors.AddressAlreadySet(Errors.AddressField.View));
+
         viewContractAddress = _viewContract;
         emit ViewContractSet(_viewContract);
     }

service_contracts/test/FilecoinWarmStorageService.t.sol

@@ -4114,10 +4114,14 @@ contract FilecoinWarmStorageServiceUpgradeTest is Test {
         warmStorageService.setViewContract(address(0x456));
 
         // Test that it cannot be set again (one-time only)
-        FilecoinWarmStorageServiceStateView newViewContract =
-            new FilecoinWarmStorageServiceStateView(warmStorageService);
-        vm.expectRevert(abi.encodeWithSelector(Errors.AddressAlreadySet.selector, Errors.AddressField.View));
-        warmStorageService.setViewContract(address(newViewContract));
+        // NOTE: This check is commented out to allow setting the view contract easily during migrations prior to GA
+        //       GH ISSUE: https://github.com/FilOzone/filecoin-services/issues/303
+        //       This check needs to be re-enabled before mainnet deployment to prevent changing the view contract later.
+
+        // FilecoinWarmStorageServiceStateView newViewContract =
+        //     new FilecoinWarmStorageServiceStateView(warmStorageService);
+        // vm.expectRevert(abi.encodeWithSelector(Errors.AddressAlreadySet.selector, Errors.AddressField.View));
+        // warmStorageService.setViewContract(address(newViewContract));
 
         // Test that zero address is rejected (would need a new contract to test this properly)
         // This is now unreachable in this test since view contract is already set