Replace Error Strings (#270)

Reviewer @rvagg
This reduces codesize 24553 -> 24108 (-445) by replacing revert strings
with solidity errors.
#### Changes
* remove error strings from initialize and setViewContract

Author: wjmelements

service_contracts/abi/FilecoinWarmStorageService.abi.json

@@ -1474,6 +1474,17 @@
     ],
     "anonymous": false
   },
+  {
+    "type": "error",
+    "name": "AddressAlreadySet",
+    "inputs": [
+      {
+        "name": "field",
+        "type": "uint8",
+        "internalType": "enum Errors.AddressField"
+      }
+    ]
+  },
   {
     "type": "error",
     "name": "AddressEmptyCode",
@@ -1819,6 +1830,28 @@
     "name": "InvalidInitialization",
     "inputs": []
   },
+  {
+    "type": "error",
+    "name": "InvalidServiceDescriptionLength",
+    "inputs": [
+      {
+        "name": "length",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ]
+  },
+  {
+    "type": "error",
+    "name": "InvalidServiceNameLength",
+    "inputs": [
+      {
+        "name": "length",
+        "type": "uint256",
+        "internalType": "uint256"
+      }
+    ]
+  },
   {
     "type": "error",
     "name": "InvalidSignature",

service_contracts/src/Errors.sol

@@ -24,7 +24,9 @@ library Errors {
         /// ServiceProviderRegistry contract address
         ServiceProviderRegistry,
         /// FilBeam beneficiary address
-        FilBeamBeneficiary
+        FilBeamBeneficiary,
+        /// View contract address
+        View
     }
 
     /// @notice Enumerates the types of commission rates used in the protocol
@@ -39,6 +41,11 @@ library Errors {
     /// @param field The specific address field that was zero (see enum {AddressField})
     error ZeroAddress(AddressField field);
 
+    /// @notice Tried to set an address that can only be set once
+    /// @dev Used for parameter validation when a non-zero address is required
+    /// @param field The specific address field already set (see enum {AddressField})
+    error AddressAlreadySet(AddressField field);
+
     /// @notice Only the PDPVerifier contract can call this function
     /// @param expected The expected PDPVerifier address
     /// @param actual The caller address
@@ -58,6 +65,14 @@ library Errors {
     /// @param challengeWindowSize The provided challenge window size
     error InvalidChallengeWindowSize(uint256 maxProvingPeriod, uint256 challengeWindowSize);
 
+    /// @notice The service name length must be >0 and <= 256
+    /// @param length the attempted length
+    error InvalidServiceNameLength(uint256 length);
+
+    /// @notice The service description length must be >0 and <= 256
+    /// @param length the attempted length
+    error InvalidServiceDescriptionLength(uint256 length);
+
     /// @notice This function can only be called by the contract itself during upgrade
     /// @param expected The expected caller (the contract address)
     /// @param actual The actual caller address

service_contracts/src/FilecoinWarmStorageService.sol

@@ -370,11 +370,13 @@ contract FilecoinWarmStorageService is
         require(_filBeamControllerAddress != address(0), Errors.ZeroAddress(Errors.AddressField.FilBeamController));
         filBeamControllerAddress = _filBeamControllerAddress;
 
-        // Validate name and description
-        require(bytes(_name).length > 0, "Service name cannot be empty");
-        require(bytes(_name).length <= 256, "Service name exceeds 256 characters");
-        require(bytes(_description).length > 0, "Service description cannot be empty");
-        require(bytes(_description).length <= 256, "Service description exceeds 256 characters");
+        uint256 serviceNameLength = bytes(_name).length;
+        require(serviceNameLength > 0, Errors.InvalidServiceNameLength(serviceNameLength));
+        require(serviceNameLength <= 256, Errors.InvalidServiceNameLength(serviceNameLength));
+
+        uint256 serviceDescriptionLength = bytes(_description).length;
+        require(serviceDescriptionLength > 0, Errors.InvalidServiceDescriptionLength(serviceDescriptionLength));
+        require(serviceDescriptionLength <= 256, Errors.InvalidServiceDescriptionLength(serviceDescriptionLength));
 
         // Emit the FilecoinServiceDeployed event
         emit FilecoinServiceDeployed(_name, _description);
@@ -441,8 +443,8 @@ contract FilecoinWarmStorageService is
      * @param _viewContract Address of the view contract
      */
     function setViewContract(address _viewContract) external onlyOwner {
-        require(_viewContract != address(0), "Invalid view contract address");
-        require(viewContractAddress == address(0), "View contract already set");
+        require(_viewContract != address(0), Errors.ZeroAddress(Errors.AddressField.View));
+        require(viewContractAddress == address(0), Errors.AddressAlreadySet(Errors.AddressField.View));
         viewContractAddress = _viewContract;
         emit ViewContractSet(_viewContract);
     }

service_contracts/test/FilecoinWarmStorageService.t.sol

@@ -372,7 +372,7 @@ contract FilecoinWarmStorageServiceTest is Test {
             "Valid description"
         );
 
-        vm.expectRevert("Service name cannot be empty");
+        vm.expectRevert(abi.encodeWithSelector(Errors.InvalidServiceNameLength.selector, 0));
         new MyERC1967Proxy(address(serviceImpl1), initDataEmptyName);
 
         // Test empty description validation
@@ -394,7 +394,7 @@ contract FilecoinWarmStorageServiceTest is Test {
             "" // empty description
         );
 
-        vm.expectRevert("Service description cannot be empty");
+        vm.expectRevert(abi.encodeWithSelector(Errors.InvalidServiceDescriptionLength.selector, 0));
         new MyERC1967Proxy(address(serviceImpl2), initDataEmptyDesc);
 
         // Test name exceeding 256 characters
@@ -426,7 +426,7 @@ contract FilecoinWarmStorageServiceTest is Test {
             "Valid description"
         );
 
-        vm.expectRevert("Service name exceeds 256 characters");
+        vm.expectRevert(abi.encodeWithSelector(Errors.InvalidServiceNameLength.selector, bytes(longName).length));
         new MyERC1967Proxy(address(serviceImpl3), initDataLongName);
 
         // Test description exceeding 256 characters
@@ -458,7 +458,7 @@ contract FilecoinWarmStorageServiceTest is Test {
             longDesc
         );
 
-        vm.expectRevert("Service description exceeds 256 characters");
+        vm.expectRevert(abi.encodeWithSelector(Errors.InvalidServiceDescriptionLength.selector, bytes(longDesc).length));
         new MyERC1967Proxy(address(serviceImpl4), initDataLongDesc);
     }
 
@@ -3779,7 +3779,7 @@ contract FilecoinWarmStorageServiceUpgradeTest is Test {
         // Test that it cannot be set again (one-time only)
         FilecoinWarmStorageServiceStateView newViewContract =
             new FilecoinWarmStorageServiceStateView(warmStorageService);
-        vm.expectRevert("View contract already set");
+        vm.expectRevert(abi.encodeWithSelector(Errors.AddressAlreadySet.selector, Errors.AddressField.View));
         warmStorageService.setViewContract(address(newViewContract));
 
         // Test that zero address is rejected (would need a new contract to test this properly)