chore: remove DeleteDataSet signature checking facilities

Signed-off-by: Jakub Sztandera <[email protected]>

Author: Kubuxu

service_contracts/src/FilecoinWarmStorageService.sol

@@ -212,8 +212,6 @@ contract FilecoinWarmStorageService is
     bytes32 private constant SCHEDULE_PIECE_REMOVALS_TYPEHASH =
         keccak256("SchedulePieceRemovals(uint256 clientDataSetId,uint256[] pieceIds)");
 
-    bytes32 private constant DELETE_DATA_SET_TYPEHASH = keccak256("DeleteDataSet(uint256 clientDataSetId)");
-
     // =========================================================================
     // Storage variables
     //
@@ -1479,32 +1477,6 @@ contract FilecoinWarmStorageService is
         );
     }
 
-    /**
-     * @notice Verifies a signature for the DeleteDataSet operation
-     * @param payer The address of the payer who should have signed the message
-     * @param clientDataSetId The ID of the data set
-     * @param signature The signature bytes (v, r, s)
-     */
-    function verifyDeleteDataSetSignature(address payer, uint256 clientDataSetId, bytes memory signature)
-        internal
-        view
-    {
-        // Prepare the message hash that was signed
-        bytes32 structHash = keccak256(abi.encode(DELETE_DATA_SET_TYPEHASH, clientDataSetId));
-        bytes32 digest = _hashTypedDataV4(structHash);
-
-        // Recover signer address from the signature
-        address recoveredSigner = recoverSigner(digest, signature);
-
-        if (payer == recoveredSigner) {
-            return;
-        }
-        require(
-            sessionKeyRegistry.authorizationExpiry(payer, recoveredSigner, DELETE_DATA_SET_TYPEHASH) >= block.timestamp,
-            Errors.InvalidSignature(payer, recoveredSigner)
-        );
-    }
-
     /**
      * @notice Recover the signer address from a signature
      * @param messageHash The signed message hash

service_contracts/test/SignatureFixtureTest.t.sol

@@ -61,8 +61,6 @@ contract MetadataSignatureTestContract is EIP712 {
     bytes32 private constant SCHEDULE_PIECE_REMOVALS_TYPEHASH =
         keccak256("SchedulePieceRemovals(uint256 clientDataSetId,uint256[] pieceIds)");
 
-    bytes32 private constant DELETE_DATA_SET_TYPEHASH = keccak256("DeleteDataSet(uint256 clientDataSetId)");
-
     // Metadata hashing functions
     function hashMetadataEntry(string memory key, string memory value) internal pure returns (bytes32) {
         return keccak256(abi.encode(METADATA_ENTRY_TYPEHASH, keccak256(bytes(key)), keccak256(bytes(value))));
@@ -180,11 +178,6 @@ contract MetadataSignatureTestContract is EIP712 {
         return _hashTypedDataV4(structHash);
     }
 
-    function getDeleteDataSetDigest(uint256 clientDataSetId) public view returns (bytes32) {
-        bytes32 structHash = keccak256(abi.encode(DELETE_DATA_SET_TYPEHASH, clientDataSetId));
-        return _hashTypedDataV4(structHash);
-    }
-
     function getDomainSeparator() public view returns (bytes32) {
         return _domainSeparatorV4();
     }
@@ -228,7 +221,6 @@ contract MetadataSignatureFixturesTest is Test {
         testPieceIds[1] = 3;
         testPieceIds[2] = 5;
         bytes memory scheduleRemovalsSig = generateSchedulePieceRemovalsSignature(testPieceIds);
-        bytes memory deleteDataSetSig = generateDeleteDataSetSignature();
 
         // Get all digests
         bytes32 createDataSetDigest =
@@ -237,7 +229,6 @@ contract MetadataSignatureFixturesTest is Test {
         bytes32 addPiecesDigest =
             testContract.getAddPiecesDigest(CLIENT_DATA_SET_ID, FIRST_ADDED, pieceCidsArray, pieceKeys, pieceValues);
         bytes32 scheduleRemovalsDigest = testContract.getSchedulePieceRemovalsDigest(CLIENT_DATA_SET_ID, testPieceIds);
-        bytes32 deleteDataSetDigest = testContract.getDeleteDataSetDigest(CLIENT_DATA_SET_ID);
 
         // Output JavaScript format for copying to synapse-sdk tests
         console.log("Copy this JavaScript const to synapse-sdk src/test/pdp-auth.test.ts:");
@@ -283,11 +274,6 @@ contract MetadataSignatureFixturesTest is Test {
         console.log("      digest: '%s',", vm.toString(scheduleRemovalsDigest));
         console.log("      clientDataSetId: %d,", CLIENT_DATA_SET_ID);
         console.log("      pieceIds: [%d, %d, %d]", testPieceIds[0], testPieceIds[1], testPieceIds[2]);
-        console.log("    },");
-        console.log("    deleteDataSet: {");
-        console.log("      signature: '%s',", vm.toString(deleteDataSetSig));
-        console.log("      digest: '%s',", vm.toString(deleteDataSetDigest));
-        console.log("      clientDataSetId: %d", CLIENT_DATA_SET_ID);
         console.log("    }");
         console.log("  }");
         console.log("}");
@@ -329,10 +315,6 @@ contract MetadataSignatureFixturesTest is Test {
         console.log("      %d,", testPieceIds[1]);
         console.log("      %d", testPieceIds[2]);
         console.log("    ]");
-        console.log("  },");
-        console.log("  \"deleteDataSet\": {");
-        console.log("    \"signature\": \"%s\",", vm.toString(deleteDataSetSig));
-        console.log("    \"clientDataSetId\": %d", CLIENT_DATA_SET_ID);
         console.log("  }");
         console.log("}");
 
@@ -410,9 +392,6 @@ contract MetadataSignatureFixturesTest is Test {
         console.log("  SchedulePieceRemovals: [");
         console.log("    { name: 'clientDataSetId', type: 'uint256' },");
         console.log("    { name: 'pieceIds', type: 'uint256[]' }");
-        console.log("  ],");
-        console.log("  DeleteDataSet: [");
-        console.log("    { name: 'clientDataSetId', type: 'uint256' }");
         console.log("  ]");
     }
 
@@ -474,12 +453,6 @@ contract MetadataSignatureFixturesTest is Test {
         return abi.encodePacked(r, s, v);
     }
 
-    function generateDeleteDataSetSignature() internal view returns (bytes memory) {
-        bytes32 digest = testContract.getDeleteDataSetDigest(CLIENT_DATA_SET_ID);
-        (uint8 v, bytes32 r, bytes32 s) = vm.sign(TEST_PRIVATE_KEY, digest);
-        return abi.encodePacked(r, s, v);
-    }
-
     // External signature validation functions
     function testCreateDataSetSignature(string memory json, address signer) internal view {
         string memory signature = vm.parseJsonString(json, ".createDataSet.signature");