fix: remove PaymentArbitrated (#301)

Author: wjmelements

service_contracts/abi/FilecoinWarmStorageService.abi.json

@@ -915,7 +915,7 @@
         ]
       }
     ],
-    "stateMutability": "nonpayable"
+    "stateMutability": "view"
   },
   {
     "type": "function",
@@ -1266,43 +1266,6 @@
     ],
     "anonymous": false
   },
-  {
-    "type": "event",
-    "name": "PaymentArbitrated",
-    "inputs": [
-      {
-        "name": "railId",
-        "type": "uint256",
-        "indexed": false,
-        "internalType": "uint256"
-      },
-      {
-        "name": "dataSetId",
-        "type": "uint256",
-        "indexed": false,
-        "internalType": "uint256"
-      },
-      {
-        "name": "originalAmount",
-        "type": "uint256",
-        "indexed": false,
-        "internalType": "uint256"
-      },
-      {
-        "name": "modifiedAmount",
-        "type": "uint256",
-        "indexed": false,
-        "internalType": "uint256"
-      },
-      {
-        "name": "faultedEpochs",
-        "type": "uint256",
-        "indexed": false,
-        "internalType": "uint256"
-      }
-    ],
-    "anonymous": false
-  },
   {
     "type": "event",
     "name": "PieceAdded",

service_contracts/src/FilecoinWarmStorageService.sol

@@ -97,11 +97,6 @@ contract FilecoinWarmStorageService is
     event ProviderApproved(uint256 indexed providerId);
     event ProviderUnapproved(uint256 indexed providerId);
 
-    // Event for validation
-    event PaymentArbitrated(
-        uint256 railId, uint256 dataSetId, uint256 originalAmount, uint256 modifiedAmount, uint256 faultedEpochs
-    );
-
     // =========================================================================
     // Structs
 
@@ -1488,7 +1483,7 @@ contract FilecoinWarmStorageService is
         uint256 fromEpoch,
         uint256 toEpoch,
         uint256 /* rate */
-    ) external override returns (ValidationResult memory result) {
+    ) external view override returns (ValidationResult memory result) {
         // Get the data set ID associated with this rail
         uint256 dataSetId = railToDataSet[railId];
         require(dataSetId != 0, Errors.RailNotAssociated(railId));
@@ -1535,9 +1530,6 @@ contract FilecoinWarmStorageService is
         // Calculate how many epochs were not proven (faulted)
         uint256 faultedEpochs = totalEpochsRequested - provenEpochCount;
 
-        // Emit event for logging
-        emit PaymentArbitrated(railId, dataSetId, proposedAmount, modifiedAmount, faultedEpochs);
-
         return ValidationResult({
             modifiedAmount: modifiedAmount,
             settleUpto: lastProvenEpoch, // Settle up to the last proven epoch

subgraph/API.md

@@ -335,7 +335,6 @@ query AllRails($first: Int, $skip: Int) {
     operator
     arbiter
     paymentRate
-    settledUpto
     endEpoch
     queueLength
     dataSet {
@@ -359,7 +358,6 @@ query RailById($railId: ID!) {
     operator
     arbiter
     paymentRate
-    settledUpto
     endEpoch
     queueLength
     dataSet {
@@ -389,7 +387,6 @@ query RailsByClient($clientAddress: Bytes!) {
     token
     to
     paymentRate
-    settledUpto
     endEpoch
     dataSet {
       id
@@ -410,7 +407,6 @@ query RailsByProvider($providerAddress: Bytes!) {
     token
     from
     paymentRate
-    settledUpto
     endEpoch
     dataSet {
       id
@@ -432,7 +428,6 @@ query HighPaymentRails($minRate: BigInt!) {
     from
     to
     paymentRate
-    settledUpto
     endEpoch
     dataSet {
       id

subgraph/schemas/schema.v1.graphql

@@ -48,9 +48,6 @@ type Rail @entity(immutable: false) {
   operator: Bytes!
   arbiter: Bytes!
   paymentRate: BigInt!
-  settledUpto: BigInt!
-  settledAmount: BigInt!
-  totalFaultedEpochs: BigInt!
   endEpoch: BigInt!
   isActive: Boolean!
   queueLength: BigInt!

subgraph/src/filecoin-warm-storage-service.ts

@@ -9,7 +9,6 @@ import {
   DataSetServiceProviderChanged as DataSetServiceProviderChangedEvent,
   PDPPaymentTerminated as PDPPaymentTerminatedEvent,
   CDNPaymentTerminated as CDNPaymentTerminatedEvent,
-  PaymentArbitrated as PaymentArbitratedEvent,
 } from "../generated/FilecoinWarmStorageService/FilecoinWarmStorageService";
 import { PDPVerifier } from "../generated/PDPVerifier/PDPVerifier";
 import { DataSet, FaultRecord, Piece, Provider, Rail, RateChangeQueue } from "../generated/schema";
@@ -535,28 +534,3 @@ export function handleCDNPaymentTerminated(event: CDNPaymentTerminatedEvent): vo
     dataSet.save();
   }
 }
-
-/**
- * Handles the PaymentArbitrated event.
- * Arbitrates a storage payment.
- */
-export function handlePaymentArbitrated(event: PaymentArbitratedEvent): void {
-  const railId = event.params.railId;
-  const dataSetId = event.params.dataSetId;
-  const arbitratedAmount = event.params.modifiedAmount;
-  const faultedEpochs = event.params.faultedEpochs;
-
-  const rail = Rail.load(getRailEntityId(railId));
-  if (!rail) {
-    log.warning("PaymentArbitrated: Rail {} not found", [railId.toString()]);
-    return;
-  }
-
-  const dataSet = DataSet.load(getDataSetEntityId(dataSetId));
-
-  rail.settledAmount = rail.settledAmount.plus(arbitratedAmount);
-  rail.totalFaultedEpochs = rail.totalFaultedEpochs.plus(faultedEpochs);
-  rail.settledUpto = dataSet ? dataSet.lastProvenEpoch : rail.settledUpto;
-
-  rail.save();
-}

subgraph/src/utils/entity.ts

@@ -30,9 +30,6 @@ export function createRails(
     rail.arbiter = listenerAddr;
     rail.dataSet = dataSetId;
     rail.paymentRate = BIGINT_ZERO;
-    rail.settledUpto = BIGINT_ZERO;
-    rail.settledAmount = BIGINT_ZERO;
-    rail.totalFaultedEpochs = BIGINT_ZERO;
     rail.endEpoch = BIGINT_ZERO;
     rail.isActive = true;
     rail.queueLength = BIGINT_ZERO;

subgraph/templates/subgraph.template.yaml

@@ -82,8 +82,6 @@ dataSources:
           handler: handlePDPPaymentTerminated
         - event: "CDNPaymentTerminated(indexed uint256,uint256,uint256,uint256)"
           handler: handleCDNPaymentTerminated
-        - event: "PaymentArbitrated(uint256,uint256,uint256,uint256,uint256)"
-          handler: handlePaymentArbitrated
       file: ./src/filecoin-warm-storage-service.ts
   # LEGACY DATA SOURCE: Indexes events from older contract versions so historical data isn’t lost
   # Example: PieceAdded event was upgraded - old had (dataSetId, pieceId, keys[], values[]), new has pieceCid param