Revert "feat(sp-registry): getProvidersWithProductByIds() to get multiple providers" (#334)

Reverts #333

I think we don't need this function because it can be replaced with a
multicall or batch jsonrpc.

Author: wjmelements

service_contracts/abi/ServiceProviderRegistry.abi.json

@@ -736,101 +736,6 @@
     ],
     "stateMutability": "view"
   },
-  {
-    "type": "function",
-    "name": "getProvidersWithProductByIds",
-    "inputs": [
-      {
-        "name": "providerIds",
-        "type": "uint256[]",
-        "internalType": "uint256[]"
-      },
-      {
-        "name": "productType",
-        "type": "uint8",
-        "internalType": "enum ServiceProviderRegistryStorage.ProductType"
-      }
-    ],
-    "outputs": [
-      {
-        "name": "providersWithProducts",
-        "type": "tuple[]",
-        "internalType": "struct ServiceProviderRegistryStorage.ProviderWithProduct[]",
-        "components": [
-          {
-            "name": "providerId",
-            "type": "uint256",
-            "internalType": "uint256"
-          },
-          {
-            "name": "providerInfo",
-            "type": "tuple",
-            "internalType": "struct ServiceProviderRegistryStorage.ServiceProviderInfo",
-            "components": [
-              {
-                "name": "serviceProvider",
-                "type": "address",
-                "internalType": "address"
-              },
-              {
-                "name": "payee",
-                "type": "address",
-                "internalType": "address"
-              },
-              {
-                "name": "name",
-                "type": "string",
-                "internalType": "string"
-              },
-              {
-                "name": "description",
-                "type": "string",
-                "internalType": "string"
-              },
-              {
-                "name": "isActive",
-                "type": "bool",
-                "internalType": "bool"
-              }
-            ]
-          },
-          {
-            "name": "product",
-            "type": "tuple",
-            "internalType": "struct ServiceProviderRegistryStorage.ServiceProduct",
-            "components": [
-              {
-                "name": "productType",
-                "type": "uint8",
-                "internalType": "enum ServiceProviderRegistryStorage.ProductType"
-              },
-              {
-                "name": "capabilityKeys",
-                "type": "string[]",
-                "internalType": "string[]"
-              },
-              {
-                "name": "isActive",
-                "type": "bool",
-                "internalType": "bool"
-              }
-            ]
-          },
-          {
-            "name": "productCapabilityValues",
-            "type": "bytes[]",
-            "internalType": "bytes[]"
-          }
-        ]
-      },
-      {
-        "name": "validIds",
-        "type": "bool[]",
-        "internalType": "bool[]"
-      }
-    ],
-    "stateMutability": "view"
-  },
   {
     "type": "function",
     "name": "initialize",

service_contracts/src/ServiceProviderRegistry.sol

@@ -638,66 +638,6 @@ contract ServiceProviderRegistry is
         }
     }
 
-    /// @notice Get multiple providers with product information by their IDs
-    /// @param providerIds Array of provider IDs to retrieve
-    /// @param productType The type of product to include in the response
-    /// @return providersWithProducts Array of provider and product information corresponding to the input IDs
-    /// @return validIds Array of booleans indicating whether each ID is valid (exists, is active, and has the product)
-    /// @dev Returns empty ProviderWithProduct structs for invalid IDs, with corresponding validIds[i] = false
-    function getProvidersWithProductByIds(uint256[] calldata providerIds, ProductType productType)
-        external
-        view
-        returns (ProviderWithProduct[] memory providersWithProducts, bool[] memory validIds)
-    {
-        uint256 length = providerIds.length;
-        providersWithProducts = new ProviderWithProduct[](length);
-        validIds = new bool[](length);
-
-        uint256 _numProviders = numProviders;
-
-        for (uint256 i = 0; i < length; i++) {
-            uint256 providerId = providerIds[i];
-
-            if (providerId > 0 && providerId <= _numProviders) {
-                ServiceProviderInfo storage provider = providers[providerId];
-                ServiceProduct storage product = providerProducts[providerId][productType];
-
-                if (provider.serviceProvider != address(0) && provider.isActive && product.isActive) {
-                    providersWithProducts[i] = ProviderWithProduct({
-                        providerId: providerId,
-                        providerInfo: provider,
-                        product: product,
-                        productCapabilityValues: getProductCapabilities(providerId, productType, product.capabilityKeys)
-                    });
-                    validIds[i] = true;
-                } else {
-                    providersWithProducts[i] = _getEmptyProviderWithProduct();
-                    validIds[i] = false;
-                }
-            } else {
-                providersWithProducts[i] = _getEmptyProviderWithProduct();
-                validIds[i] = false;
-            }
-        }
-    }
-
-    /// @notice Internal helper to create an empty ProviderWithProduct
-    /// @return Empty ProviderWithProduct struct
-    function _getEmptyProviderWithProduct() internal pure returns (ProviderWithProduct memory) {
-        return ProviderWithProduct({
-            providerId: 0,
-            providerInfo: ServiceProviderInfo({
-                serviceProvider: address(0),
-                payee: address(0),
-                name: "",
-                description: "",
-                isActive: false
-            }),
-            product: ServiceProduct({productType: ProductType.PDP, capabilityKeys: new string[](0), isActive: false}),
-            productCapabilityValues: new bytes[](0)
-        });
-    }
-
     /// @notice Internal helper to create an empty ServiceProviderInfoView
     /// @return Empty ServiceProviderInfoView struct
     function _getEmptyProviderInfoView() internal pure returns (ServiceProviderInfoView memory) {