Skip to content

Commit 9db6e30

Browse files
committed
fix: remove getDataSetStatusDetails function from state libraries
Remove getDataSetStatusDetails function and extensive documentation files per code review.
1 parent f7d2193 commit 9db6e30

8 files changed

+0
-1532
lines changed

service_contracts/README.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,6 @@ import {FilecoinWarmStorageServiceStateLibrary} from "./lib/FilecoinWarmStorageS
4949
// Get status
5050
DataSetStatus status = FilecoinWarmStorageServiceStateLibrary.getDataSetStatus(service, dataSetId);
5151
bool isActive = (status == FilecoinWarmStorageService.DataSetStatus.Active);
52-
53-
// Get detailed status
54-
(
55-
DataSetStatus status,
56-
bool hasProving,
57-
bool isTerminating
58-
) = FilecoinWarmStorageServiceStateLibrary.getDataSetStatusDetails(service, dataSetId);
5952
```
6053

6154
**From Subgraph:**
@@ -76,13 +69,6 @@ DataSetStatus status = viewContract.getDataSetStatus(dataSetId);
7669
// 0 = Inactive, 1 = Active
7770
```
7871

79-
### Documentation
80-
81-
For complete information on dataset lifecycle, status transitions, and integration examples:
82-
83-
- [Dataset Lifecycle Documentation](./docs/dataset-lifecycle.md) - Complete lifecycle guide with state diagram
84-
- [Integration Guide](./docs/integration-guide.md) - How to integrate status checking into your application
85-
8672
### Extsload
8773
The allow for many view methods within the 24 KiB contract size constraint, viewing is done with `extsload` and `extsloadStruct`.
8874
There are three recommended ways to access `view` methods.

service_contracts/abi/FilecoinWarmStorageServiceStateLibrary.abi.json

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -453,40 +453,6 @@
453453
],
454454
"stateMutability": "view"
455455
},
456-
{
457-
"type": "function",
458-
"name": "getDataSetStatusDetails",
459-
"inputs": [
460-
{
461-
"name": "service",
462-
"type": "FilecoinWarmStorageService",
463-
"internalType": "contract FilecoinWarmStorageService"
464-
},
465-
{
466-
"name": "dataSetId",
467-
"type": "uint256",
468-
"internalType": "uint256"
469-
}
470-
],
471-
"outputs": [
472-
{
473-
"name": "status",
474-
"type": "FilecoinWarmStorageService.DataSetStatus",
475-
"internalType": "enum FilecoinWarmStorageService.DataSetStatus"
476-
},
477-
{
478-
"name": "hasProving",
479-
"type": "bool",
480-
"internalType": "bool"
481-
},
482-
{
483-
"name": "isTerminating",
484-
"type": "bool",
485-
"internalType": "bool"
486-
}
487-
],
488-
"stateMutability": "view"
489-
},
490456
{
491457
"type": "function",
492458
"name": "getMaxProvingPeriod",

service_contracts/abi/FilecoinWarmStorageServiceStateView.abi.json

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -401,35 +401,6 @@
401401
],
402402
"stateMutability": "view"
403403
},
404-
{
405-
"type": "function",
406-
"name": "getDataSetStatusDetails",
407-
"inputs": [
408-
{
409-
"name": "dataSetId",
410-
"type": "uint256",
411-
"internalType": "uint256"
412-
}
413-
],
414-
"outputs": [
415-
{
416-
"name": "status",
417-
"type": "uint8",
418-
"internalType": "enum FilecoinWarmStorageService.DataSetStatus"
419-
},
420-
{
421-
"name": "hasProving",
422-
"type": "bool",
423-
"internalType": "bool"
424-
},
425-
{
426-
"name": "isTerminating",
427-
"type": "bool",
428-
"internalType": "bool"
429-
}
430-
],
431-
"stateMutability": "view"
432-
},
433404
{
434405
"type": "function",
435406
"name": "getMaxProvingPeriod",

0 commit comments

Comments
 (0)