refactor: use camelCase for pricing storage variables

refactor: use camelCase for pricing storage variables

Author: rjan90

service_contracts/src/FilecoinWarmStorageService.sol

@@ -268,9 +268,9 @@ contract FilecoinWarmStorageService is
     PlannedUpgrade private nextUpgrade;
 
     // Pricing rates (mutable for future adjustments)
-    uint256 private STORAGE_PRICE_PER_TIB_PER_MONTH;
-    uint256 private CACHE_MISS_PRICE_PER_TIB_PER_MONTH;
-    uint256 private CDN_PRICE_PER_TIB_PER_MONTH;
+    uint256 private storagePricePerTibPerMonth;
+    uint256 private cacheMissPricePerTibPerMonth;
+    uint256 private cdnPricePerTibPerMonth;
 
     event UpgradeAnnounced(PlannedUpgrade plannedUpgrade);
 
@@ -379,9 +379,9 @@ contract FilecoinWarmStorageService is
         serviceCommissionBps = 0; // 0%
 
         // Initialize pricing rates based on token decimals
-        STORAGE_PRICE_PER_TIB_PER_MONTH = (5 * 10 ** TOKEN_DECIMALS) / 2; // 2.5 USDFC
-        CACHE_MISS_PRICE_PER_TIB_PER_MONTH = (1 * 10 ** TOKEN_DECIMALS) / 2; // 0.5 USDFC
-        CDN_PRICE_PER_TIB_PER_MONTH = (1 * 10 ** TOKEN_DECIMALS) / 2; // 0.5 USDFC
+        storagePricePerTibPerMonth = (5 * 10 ** TOKEN_DECIMALS) / 2; // 2.5 USDFC
+        cacheMissPricePerTibPerMonth = (1 * 10 ** TOKEN_DECIMALS) / 2; // 0.5 USDFC
+        cdnPricePerTibPerMonth = (1 * 10 ** TOKEN_DECIMALS) / 2; // 0.5 USDFC
     }
 
     function announcePlannedUpgrade(PlannedUpgrade calldata plannedUpgrade) external onlyOwner {
@@ -480,17 +480,17 @@ contract FilecoinWarmStorageService is
         require(newStoragePrice > 0 || newCacheMissPrice > 0 || newCdnPrice > 0, "At least one price must be non-zero");
 
         if (newStoragePrice > 0) {
-            STORAGE_PRICE_PER_TIB_PER_MONTH = newStoragePrice;
+            storagePricePerTibPerMonth = newStoragePrice;
         }
         if (newCacheMissPrice > 0) {
-            CACHE_MISS_PRICE_PER_TIB_PER_MONTH = newCacheMissPrice;
+            cacheMissPricePerTibPerMonth = newCacheMissPrice;
         }
         if (newCdnPrice > 0) {
-            CDN_PRICE_PER_TIB_PER_MONTH = newCdnPrice;
+            cdnPricePerTibPerMonth = newCdnPrice;
         }
 
         emit PricingUpdated(
-            STORAGE_PRICE_PER_TIB_PER_MONTH, CACHE_MISS_PRICE_PER_TIB_PER_MONTH, CDN_PRICE_PER_TIB_PER_MONTH
+            storagePricePerTibPerMonth, cacheMissPricePerTibPerMonth, cdnPricePerTibPerMonth
         );
     }
 
@@ -1230,9 +1230,9 @@ contract FilecoinWarmStorageService is
         view
         returns (uint256 storageRate, uint256 cacheMissRate, uint256 cdnRate)
     {
-        storageRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, STORAGE_PRICE_PER_TIB_PER_MONTH);
-        cacheMissRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, CACHE_MISS_PRICE_PER_TIB_PER_MONTH);
-        cdnRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, CDN_PRICE_PER_TIB_PER_MONTH);
+        storageRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, storagePricePerTibPerMonth);
+        cacheMissRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, cacheMissPricePerTibPerMonth);
+        cdnRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, cdnPricePerTibPerMonth);
     }
 
     /**
@@ -1241,7 +1241,7 @@ contract FilecoinWarmStorageService is
      * @return The storage rate per epoch
      */
     function _calculateStorageRate(uint256 totalBytes) internal view returns (uint256) {
-        return calculateStorageSizeBasedRatePerEpoch(totalBytes, STORAGE_PRICE_PER_TIB_PER_MONTH);
+        return calculateStorageSizeBasedRatePerEpoch(totalBytes, storagePricePerTibPerMonth);
     }
 
     /**
@@ -1251,8 +1251,8 @@ contract FilecoinWarmStorageService is
      * @return cdnRate The CDN rate per epoch
      */
     function _calculateCDNRates(uint256 totalBytes) internal view returns (uint256 cacheMissRate, uint256 cdnRate) {
-        cacheMissRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, CACHE_MISS_PRICE_PER_TIB_PER_MONTH);
-        cdnRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, CDN_PRICE_PER_TIB_PER_MONTH);
+        cacheMissRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, cacheMissPricePerTibPerMonth);
+        cdnRate = calculateStorageSizeBasedRatePerEpoch(totalBytes, cdnPricePerTibPerMonth);
     }
 
     /**
@@ -1346,8 +1346,8 @@ contract FilecoinWarmStorageService is
      */
     function getServicePrice() external view returns (ServicePricing memory pricing) {
         pricing = ServicePricing({
-            pricePerTiBPerMonthNoCDN: STORAGE_PRICE_PER_TIB_PER_MONTH,
-            pricePerTiBPerMonthWithCDN: STORAGE_PRICE_PER_TIB_PER_MONTH + CDN_PRICE_PER_TIB_PER_MONTH,
+            pricePerTiBPerMonthNoCDN: storagePricePerTibPerMonth,
+            pricePerTiBPerMonthWithCDN: storagePricePerTibPerMonth + cdnPricePerTibPerMonth,
             tokenAddress: usdfcTokenAddress,
             epochsPerMonth: EPOCHS_PER_MONTH
         });
@@ -1364,7 +1364,7 @@ contract FilecoinWarmStorageService is
         view
         returns (uint256 storagePrice, uint256 cacheMissPrice, uint256 cdnPrice)
     {
-        return (STORAGE_PRICE_PER_TIB_PER_MONTH, CACHE_MISS_PRICE_PER_TIB_PER_MONTH, CDN_PRICE_PER_TIB_PER_MONTH);
+        return (storagePricePerTibPerMonth, cacheMissPricePerTibPerMonth, cdnPricePerTibPerMonth);
     }
 
     /**
@@ -1373,7 +1373,7 @@ contract FilecoinWarmStorageService is
      * @return spPayment SP payment (per TiB per month)
      */
     function getEffectiveRates() external view returns (uint256 serviceFee, uint256 spPayment) {
-        uint256 total = STORAGE_PRICE_PER_TIB_PER_MONTH;
+        uint256 total = storagePricePerTibPerMonth;
 
         serviceFee = (total * serviceCommissionBps) / COMMISSION_MAX_BPS;
         spPayment = total - serviceFee;

service_contracts/src/lib/FilecoinWarmStorageServiceLayout.sol

@@ -25,3 +25,6 @@ bytes32 constant APPROVED_PROVIDER_IDS_SLOT = bytes32(uint256(16));
 bytes32 constant VIEW_CONTRACT_ADDRESS_SLOT = bytes32(uint256(17));
 bytes32 constant FIL_BEAM_CONTROLLER_ADDRESS_SLOT = bytes32(uint256(18));
 bytes32 constant NEXT_UPGRADE_SLOT = bytes32(uint256(19));
+bytes32 constant STORAGE_PRICE_PER_TIB_PER_MONTH_SLOT = bytes32(uint256(20));
+bytes32 constant CACHE_MISS_PRICE_PER_TIB_PER_MONTH_SLOT = bytes32(uint256(21));
+bytes32 constant CDN_PRICE_PER_TIB_PER_MONTH_SLOT = bytes32(uint256(22));