Skip to content

Commit cd6f99b

Browse files
committed
fixup! feat: add ipniPeerId to PDPOffering in ServiceProviderRegistry
1 parent 4335837 commit cd6f99b

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

service_contracts/test/ServiceProviderRegistryFull.t.sol

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1836,7 +1836,8 @@ contract ServiceProviderRegistryFullTest is Test {
18361836

18371837
function testRegisterWithMaxLengthIpniPeerId() public {
18381838
// Create a 256-character string (max length for CIDv1 base32)
1839-
string memory maxPeerId = "bafzbeiaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
1839+
string memory maxPeerId =
1840+
"bafzbeiaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
18401841
require(bytes(maxPeerId).length == 256, "Test string should be exactly 256 chars");
18411842

18421843
ServiceProviderRegistryStorage.PDPOffering memory validPDP = defaultPDPData;
@@ -1865,7 +1866,8 @@ contract ServiceProviderRegistryFullTest is Test {
18651866

18661867
function testRegisterWithTooLongIpniPeerId() public {
18671868
// Create a 257-character string (exceeds max)
1868-
string memory longPeerId = "bafzbeiaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
1869+
string memory longPeerId =
1870+
"bafzbeiaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
18691871
require(bytes(longPeerId).length == 257, "Test string should be exactly 257 chars");
18701872

18711873
ServiceProviderRegistryStorage.PDPOffering memory invalidPDP = defaultPDPData;
@@ -1941,7 +1943,9 @@ contract ServiceProviderRegistryFullTest is Test {
19411943
bytes memory encodedUpdatedData = abi.encode(updatedData);
19421944

19431945
vm.prank(provider1);
1944-
registry.updateProduct(ServiceProviderRegistryStorage.ProductType.PDP, encodedUpdatedData, emptyKeys, emptyValues);
1946+
registry.updateProduct(
1947+
ServiceProviderRegistryStorage.ProductType.PDP, encodedUpdatedData, emptyKeys, emptyValues
1948+
);
19451949

19461950
// Verify update
19471951
(ServiceProviderRegistryStorage.PDPOffering memory updatedStored,,) = registry.getPDPService(providerId);
@@ -1966,14 +1970,17 @@ contract ServiceProviderRegistryFullTest is Test {
19661970
);
19671971

19681972
// Try to update with too long peer ID (257 chars)
1969-
string memory longPeerId = "bafzbeiaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
1973+
string memory longPeerId =
1974+
"bafzbeiaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
19701975

19711976
ServiceProviderRegistryStorage.PDPOffering memory invalidData = updatedPDPData;
19721977
invalidData.ipniPeerId = longPeerId;
19731978
bytes memory encodedInvalidData = abi.encode(invalidData);
19741979

19751980
vm.prank(provider1);
19761981
vm.expectRevert("IPNI peer ID too long");
1977-
registry.updateProduct(ServiceProviderRegistryStorage.ProductType.PDP, encodedInvalidData, emptyKeys, emptyValues);
1982+
registry.updateProduct(
1983+
ServiceProviderRegistryStorage.ProductType.PDP, encodedInvalidData, emptyKeys, emptyValues
1984+
);
19781985
}
19791986
}

0 commit comments

Comments
 (0)