Skip to content

Improve upgrade‑only deployment flow #394

@rjan90

Description

@rjan90

When deploying only a new FilecoinWarmStorageService implementation for an upgrade, the deploy-warm-storage-implementation-only.sh script does not update deployments.json. Meanwhile [deploy-all-warm-storage.sh](https://github.com/FilOzone/filecoin-services/blob/main/service_contracts/tools/deploy-all-warm-storage.sh) does update addresses in deployments.json but also sets the view contract address on-chain, which is an unwanted side effect for upgrade‑only workflows.

Problem

We have two imperfect paths:

  • deploy-warm-storage-implementation-only.sh has the correct side‑effects (only deploys impl) but does not persist new addresses to deployments.json.
  • deploy-all-warm-storage.sh updates addresses but also sets the view contract, which we may not want to change or re‑set during an upgrade‑only deployment.

Proposed options

We need a decision on either of these options:

  1. Add deployments.json updates to deploy-warm-storage-implementation-only.sh
  • Write FWSS_IMPLEMENTATION_ADDRESS (and SIGNATURE_VERIFICATION_LIB_ADDRESS if deployed) + metadata.
  1. Add configurability to deploy-all-warm-storage.sh
  • Introduce a flag like SKIP_SET_VIEW=true or ONLY_DEPLOY_IMPLEMENTATION=true that skips the view‑setting step and other non‑required actions

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    ⌚️ Issue awaiting PR merge

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions