-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Milestone
Description
When deploying only a new FilecoinWarmStorageService implementation for an upgrade, the deploy-warm-storage-implementation-only.sh script does not update deployments.json. Meanwhile [deploy-all-warm-storage.sh](https://github.com/FilOzone/filecoin-services/blob/main/service_contracts/tools/deploy-all-warm-storage.sh) does update addresses in deployments.json but also sets the view contract address on-chain, which is an unwanted side effect for upgrade‑only workflows.
Problem
We have two imperfect paths:
deploy-warm-storage-implementation-only.shhas the correct side‑effects (only deploys impl) but does not persist new addresses to deployments.json.deploy-all-warm-storage.shupdates addresses but also sets the view contract, which we may not want to change or re‑set during an upgrade‑only deployment.
Proposed options
We need a decision on either of these options:
- Add
deployments.jsonupdates todeploy-warm-storage-implementation-only.sh
- Write FWSS_IMPLEMENTATION_ADDRESS (and SIGNATURE_VERIFICATION_LIB_ADDRESS if deployed) + metadata.
- Add configurability to deploy-all-warm-storage.sh
- Introduce a flag like
SKIP_SET_VIEW=trueorONLY_DEPLOY_IMPLEMENTATION=truethat skips the view‑setting step and other non‑required actions
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
⌚️ Issue awaiting PR merge