fix(warm-storage): check metadata withCDN key in addition to cdnRailId for CDN status

Fixes: #184

Author: rvagg

packages/synapse-sdk/src/storage/context.ts

@@ -436,7 +436,7 @@ export class StorageContext {
       )
     }
 
-    const withCDN = dataSetInfo.cdnRailId > 0
+    const withCDN = dataSetInfo.cdnRailId > 0 && METADATA_KEYS.WITH_CDN in dataSetMetadata
     if (options.withCDN != null && withCDN !== options.withCDN) {
       throw createError(
         'StorageContext',

packages/synapse-sdk/src/types.ts

@@ -237,7 +237,7 @@ export interface EnhancedDataSetInfo extends DataSetInfo {
   isLive: boolean
   /** Whether this data set is managed by the current Warm Storage contract */
   isManaged: boolean
-  /** Whether the data set is using CDN (derived from cdnRailId > 0) */
+  /** Whether the data set is using CDN (cdnRailId > 0 and withCDN metadata key present) */
   withCDN: boolean
   /** Metadata associated with this data set (key-value pairs) */
   metadata: Record<string, string>

packages/synapse-sdk/src/warm-storage/service.ts

@@ -31,7 +31,13 @@ import type { PaymentsService } from '../payments/service.ts'
 import type { DataSetCreationStatusResponse, PDPServer } from '../pdp/server.ts'
 import { PDPVerifier } from '../pdp/verifier.ts'
 import type { DataSetInfo, EnhancedDataSetInfo } from '../types.ts'
-import { CONTRACT_ADDRESSES, SIZE_CONSTANTS, TIME_CONSTANTS, TIMING_CONSTANTS } from '../utils/constants.ts'
+import {
+  CONTRACT_ADDRESSES,
+  METADATA_KEYS,
+  SIZE_CONSTANTS,
+  TIME_CONSTANTS,
+  TIMING_CONSTANTS,
+} from '../utils/constants.ts'
 import { CONTRACT_ABIS, createError, getFilecoinNetworkType, TOKENS } from '../utils/index.ts'
 
 /**
@@ -378,7 +384,7 @@ export class WarmStorageService {
           currentPieceCount: Number(nextPieceId),
           isLive,
           isManaged,
-          withCDN: base.cdnRailId > 0,
+          withCDN: base.cdnRailId > 0 && METADATA_KEYS.WITH_CDN in metadata,
           metadata,
         }
       } catch (error) {