Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Commit 1b469f7

Browse files
committed
Code smell was fixed with different naming. 10/10 sonar.
1 parent d892312 commit 1b469f7

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/main/java/de/filefighter/rest/configuration/RestConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class RestConfiguration {
99
public static final String FS_BASE_URI = "/filesystem/";
1010
public static final String FS_PATH_HEADER = "X-FF-PATH";
1111
public static final String USER_BASE_URI = "/users/";
12-
public static final String DEFAULT_ERROR_PATH = "/error";
12+
public static final String DEFAULT_ERROR_URI = "/error";
1313

1414
private RestConfiguration(){
1515
// Cannot be inst

src/main/java/de/filefighter/rest/rest/RestErrorController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@
77
import org.springframework.web.bind.annotation.RestController;
88
import springfox.documentation.annotations.ApiIgnore;
99

10-
import static de.filefighter.rest.configuration.RestConfiguration.DEFAULT_ERROR_PATH;
10+
import static de.filefighter.rest.configuration.RestConfiguration.DEFAULT_ERROR_URI;
1111

1212
@ApiIgnore
1313
@RestController
1414
public class RestErrorController implements ErrorController {
1515

16-
@GetMapping(value = DEFAULT_ERROR_PATH)
16+
@GetMapping(value = DEFAULT_ERROR_URI)
1717
public ResponseEntity<ServerResponse> error() {
1818
return new ResponseEntity<>(new ServerResponse(HttpStatus.NOT_FOUND, "This endpoint does not exist."), HttpStatus.NOT_FOUND);
1919
}
2020

2121
@Override
2222
public String getErrorPath() {
23-
return DEFAULT_ERROR_PATH;
23+
return DEFAULT_ERROR_URI;
2424
}
2525
}

src/test/java/de/filefighter/rest/rest/RestErrorControllerUnitTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import org.springframework.test.web.servlet.MockMvc;
66
import org.springframework.test.web.servlet.setup.MockMvcBuilders;
77

8-
import static de.filefighter.rest.configuration.RestConfiguration.DEFAULT_ERROR_PATH;
8+
import static de.filefighter.rest.configuration.RestConfiguration.DEFAULT_ERROR_URI;
99
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
1010
import static org.junit.jupiter.api.Assertions.assertEquals;
1111
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
@@ -25,7 +25,7 @@ void setUp() {
2525
@Test
2626
void errorHandlingDoesWork() {
2727
assertDoesNotThrow(() ->
28-
mockMvc.perform(get(DEFAULT_ERROR_PATH))
28+
mockMvc.perform(get(DEFAULT_ERROR_URI))
2929
.andExpect(status().is(404))
3030
.andReturn());
3131
}
@@ -34,6 +34,6 @@ void errorHandlingDoesWork() {
3434
void getErrorPath() {
3535
String actualPath = restErrorController.getErrorPath();
3636

37-
assertEquals(DEFAULT_ERROR_PATH, actualPath);
37+
assertEquals(DEFAULT_ERROR_URI, actualPath);
3838
}
3939
}

0 commit comments

Comments
 (0)