Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Commit 8e43264

Browse files
committed
FF-255 updated tests.
1 parent 283d482 commit 8e43264

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

src/test/java/de/filefighter/rest/domain/user/business/UserBusinessServiceUnitTest.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,11 @@ void registerNewUserThrows() {
250250
ex = assertThrows(UserNotRegisteredException.class, () ->
251251
userBusinessService.registerNewUser(userRegisterForm));
252252
assertEquals("User could not be registered. One or more groups do not exist.", ex.getMessage());
253+
254+
userRegisterForm.setGroupIds(new long[]{Groups.SYSTEM.getGroupId()});
255+
ex = assertThrows(UserNotRegisteredException.class, () ->
256+
userBusinessService.registerNewUser(userRegisterForm));
257+
assertEquals("User could not be registered. New users cannot be in group '" + Groups.SYSTEM.getDisplayName() + "'.", ex.getMessage());
253258
}
254259

255260
@Test
@@ -299,6 +304,11 @@ void updateUserThrows() {
299304
userBusinessService.updateUser(userId, userRegisterForm1, authenticatedUser));
300305
assertEquals("User could not get updated. User does not exist, use register endpoint.", ex.getMessage());
301306

307+
when(userRepositoryMock.findByUserId(userId)).thenReturn(UserEntity.builder().groupIds(new long[]{Groups.SYSTEM.getGroupId()}).build());
308+
ex = assertThrows(UserNotUpdatedException.class, () ->
309+
userBusinessService.updateUser(userId, userRegisterForm1, authenticatedUser));
310+
assertEquals("User could not get updated. Runtime users cannot be modified.", ex.getMessage());
311+
302312
when(userRepositoryMock.findByUserId(userId)).thenReturn(userEntityMock);
303313
ex = assertThrows(UserNotUpdatedException.class, () ->
304314
userBusinessService.updateUser(userId, userRegisterForm1, authenticatedUser));
@@ -414,6 +424,13 @@ void updateGroupsThrows() {
414424
ex = assertThrows(UserNotUpdatedException.class, () ->
415425
userBusinessService.updateUser(userId, userRegisterForm, authenticatedUser));
416426
assertEquals("User could not get updated. One or more groups do not exist.", ex.getMessage());
427+
428+
long[] systemUser = new long[]{Groups.SYSTEM.getGroupId()};
429+
userRegisterForm.setGroupIds(systemUser);
430+
when(groupRepositoryMock.getGroupsByIds(systemUser)).thenReturn(new Groups[]{Groups.SYSTEM});
431+
ex = assertThrows(UserNotUpdatedException.class, () ->
432+
userBusinessService.updateUser(userId, userRegisterForm, authenticatedUser));
433+
assertEquals("User could not get updated. Users cannot be added to the '" + Groups.SYSTEM.getDisplayName() + "' Group", ex.getMessage());
417434
}
418435

419436
@Test

0 commit comments

Comments
 (0)